Allow for a uniq-only match #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With tests now, how awesome is that?! :) |
|
Pretty awesome! I trust you on the automated testing side, but the uniq matching looks great. |
This allows for DeviceMatch=usb:1234:5678||someuniq
Previously we would match for name first, then uniq. But the name matches are less reliable than uniq matches so where we can match for uniq we should prefer that. This avoids the case where where a name that applies to multiple devices takes precedence over a more precise uniq match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit extracted from @JoseExposito's patchset in #659 but I think this needs a behaviour change to allow for uniq-only matches to take precedence over name matches, see #659 (comment)
Draft because it's untested and to test this we should add #677 and #676 first so we can test this properly.