Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #55

Merged
merged 3 commits into from
Nov 21, 2023
Merged

update dependencies #55

merged 3 commits into from
Nov 21, 2023

Conversation

glass-ships
Copy link
Contributor

bioregistry no longer requires pydantic <2

This will allow for prefixmaps to open up its pydantic specification, and thus multiple other
packages such as koza, monarch-ingest, monarch-app, to update to pydantic v2

currently test fails on AttributeError: module 'bioregistry' has no attribute 'get_extended_prefix_map'

@cthoyt
Copy link
Collaborator

cthoyt commented Nov 21, 2023

@glass-ships I changed this part of the Bioregistry's public interface, there's also a corresponding fix in https://github.com/linkml/prefixmaps/pull/52/files

@cthoyt
Copy link
Collaborator

cthoyt commented Nov 21, 2023

@glass-ships it's also the case that bioregistry isn't a runtime requirement for prefixmaps, it's only used for regenerating the Bioregistry and merged prefix map

@glass-ships
Copy link
Contributor Author

thanks @cthoyt! i noticed a comment in another PR that mentioned there was some overlap between this and others - let me know if my PR is redundant, I'd be happy to close as a duplicate

@sierra-moxon sierra-moxon self-requested a review November 21, 2023 17:03
@sierra-moxon sierra-moxon merged commit aef6fb5 into main Nov 21, 2023
5 checks passed
@glass-ships glass-ships deleted the update-dependencies branch November 21, 2023 17:05
@cthoyt
Copy link
Collaborator

cthoyt commented Nov 21, 2023

Thanks @glass-ships! Happy you were able to pull out this part and keep the "single responsibility principle" :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants