-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add support for python 3.12 #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intend to only update the lock file? Without changes in pyproject.toml these could be overwritten in future PRs
The dependency on I would say, that either we add a test for Python v3.12 or we declare that dependency in the I'm not sure either if the demand for this PR really exists. I've only stumbled upon it and thought it would make sense to add support for the latest Python version. |
Looking at the tests I can tell that no validation is taking place for Python 2.7, 3.5 and 3.6 anyway. So removing support for those Python releases is probably not so bad. |
Trying out the testing approach proposed here, marking as draft until tests run for Python v.3.12. |
19c94d1
to
4c99164
Compare
842eeca
to
f285e87
Compare
Following draft PRs on linkml-runtime and linkml will help distributing the support for Python 3.12 to those components: |
f285e87
to
c169ace
Compare
ea182dd
to
64f5365
Compare
Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
In order to catch dependency issues with greenlet on python 3.12 caches should be Python version dependent. Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
Upgrading greenlet, pyYAML and typing_extensions versions to have support for Python v3.12. See here for more information: python-greenlet/greenlet#323 Closes #45 Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
64f5365
to
d0c339a
Compare
038de55
to
fe92db4
Compare
fe92db4
to
2d5ee07
Compare
Thanks to #54 from @cmungall I got the solution to the issue that was blocking this PR. I've integrated his commit (to keep attribution), but updated the Poetry lock accordingly extending his commit. It's now ready for integration, removing the 'Draft' marker and retriggering review. |
@sierra-moxon we have already 3 prefixmaps PRs with some overlapping:
It would be meaningful to merge at least one of them and then reconsider if something is left over that should be covered by a 2nd one. #54 is in any case covered by #53 and #55. I personally would go for this one (not only because it's mine, but because it validates support for Python 3.12 and has a "green" pipeline), rebasing #55 and reconsidering if what's left is needed or not. |
Upgrading greenlet version to have support for Python 3.12. See here for more information: python-greenlet/greenlet#323
Closes #45