Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for python 3.12 #53

Merged
merged 4 commits into from
Nov 21, 2023
Merged

chore: add support for python 3.12 #53

merged 4 commits into from
Nov 21, 2023

Conversation

Silvanoc
Copy link
Contributor

@Silvanoc Silvanoc commented Nov 6, 2023

Upgrading greenlet version to have support for Python 3.12. See here for more information: python-greenlet/greenlet#323

⚠️ WARNING! This PR is removing support for Python 2.7, 3.5 and 3.6.

Closes #45

@Silvanoc Silvanoc marked this pull request as draft November 6, 2023 08:55
@Silvanoc Silvanoc marked this pull request as ready for review November 6, 2023 08:59
@Silvanoc Silvanoc requested a review from sierra-moxon November 6, 2023 09:02
Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to only update the lock file? Without changes in pyproject.toml these could be overwritten in future PRs

@Silvanoc
Copy link
Contributor Author

Silvanoc commented Nov 6, 2023

Did you intend to only update the lock file? Without changes in pyproject.toml these could be overwritten in future PRs

The dependency on greenlet is not being explicitly declared in the pyprojects.toml file, that's why I've only updated the lock file.

I would say, that either we add a test for Python v3.12 or we declare that dependency in the pyprojects.toml file to avoid that the change can get reverted in the future.

I'm not sure either if the demand for this PR really exists. I've only stumbled upon it and thought it would make sense to add support for the latest Python version.

@Silvanoc
Copy link
Contributor Author

Silvanoc commented Nov 9, 2023

Looking at the tests I can tell that no validation is taking place for Python 2.7, 3.5 and 3.6 anyway. So removing support for those Python releases is probably not so bad.

@Silvanoc Silvanoc marked this pull request as draft November 9, 2023 00:29
@Silvanoc
Copy link
Contributor Author

Silvanoc commented Nov 9, 2023

Trying out the testing approach proposed here, marking as draft until tests run for Python v.3.12.

@Silvanoc Silvanoc marked this pull request as ready for review November 9, 2023 07:49
@Silvanoc
Copy link
Contributor Author

Silvanoc commented Nov 9, 2023

Following draft PRs on linkml-runtime and linkml will help distributing the support for Python 3.12 to those components:

@Silvanoc Silvanoc marked this pull request as draft November 9, 2023 08:39
@Silvanoc Silvanoc force-pushed the update-greenlet branch 2 times, most recently from ea182dd to 64f5365 Compare November 9, 2023 11:41
Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
In order to catch dependency issues with greenlet on python 3.12 caches
should be Python version dependent.

Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
Upgrading greenlet, pyYAML and typing_extensions versions to have support for
Python v3.12.
See here for more information: python-greenlet/greenlet#323

Closes #45

Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
@Silvanoc
Copy link
Contributor Author

Thanks to #54 from @cmungall I got the solution to the issue that was blocking this PR. I've integrated his commit (to keep attribution), but updated the Poetry lock accordingly extending his commit.

It's now ready for integration, removing the 'Draft' marker and retriggering review.

@Silvanoc Silvanoc marked this pull request as ready for review November 14, 2023 08:41
@Silvanoc Silvanoc requested a review from cmungall November 14, 2023 08:41
@Silvanoc
Copy link
Contributor Author

@sierra-moxon we have already 3 prefixmaps PRs with some overlapping:

It would be meaningful to merge at least one of them and then reconsider if something is left over that should be covered by a 2nd one. #54 is in any case covered by #53 and #55.

I personally would go for this one (not only because it's mine, but because it validates support for Python 3.12 and has a "green" pipeline), rebasing #55 and reconsidering if what's left is needed or not.

@sierra-moxon sierra-moxon merged commit d37aa81 into main Nov 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Python 3.12
3 participants