Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a broken template of React #43

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Fix a broken template of React #43

merged 1 commit into from
Jan 24, 2025

Conversation

shogo0421
Copy link
Contributor

@shogo0421 shogo0421 commented Jan 23, 2025 •
edited
Loading

Closes #42 (only react issue is resolved.)

fix: update react template

✅ Pull Request Checklist:

  • Included link to corresponding GitHub Issue.
  • Filled out test instructions.

📝 Test Instructions:

create app using react-typescript and react-javascript template

yarn install
yarn start

@shogo0421 shogo0421 requested a review from a team as a code owner January 23, 2025 04:29
@shogo0421 shogo0421 mentioned this pull request Jan 23, 2025
Merged
2 tasks
@odanado odanado added the type: bug Bug Report label Jan 24, 2025
@odanado odanado changed the title fix react template Fix a broken template of React Jan 24, 2025
odanado
odanado approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@odanado odanado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!Thank you!

@odanado odanado merged commit 09b5908 into line:main Jan 24, 2025
@shogo0421 shogo0421 deleted the feature/update-react-template branch January 25, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odanado odanado odanado approved these changes

Assignees
No one assigned
Labels
type: bug Bug Report
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shogo0421 @odanado