Add ci workflow & update react template #31
Conversation
templates/react-ts/src/main.tsx
Outdated
|
|
||
| ReactDOM.render( |
There was a problem hiding this comment.
ReactDOM.render is deprecated.
There was a problem hiding this comment.
Thank you for your suggestion.
We would like to avoid making multiple changes to a single pull request.
Could you create a separate pull request for React?
package.json
Outdated
| "lint": "eslint '**/*.{ts,js}'", | ||
| "fix:lint": "yarn lint --fix", | ||
| "format": "prettier --check '**/*.{ts,js,json,md}'", | ||
| "fix:format": "prettier --write .", |
There was a problem hiding this comment.
Can I format all files and commit in this PR?
| @@ -0,0 +1,26 @@ | |||
| name: Check code health | |||
There was a problem hiding this comment.
ref: workflow in line/liff-inspector
This workflow is not currently running in this repository.
However, it is running in my forked repository, and there are no errors.
https://github.com/shogo0421/create-liff-app/actions/runs/11549522724
github docs (about-workflow-runs-from-public-forks)
workflows on pull requests to public repositories from some outside contributors will not run automatically, and might need to be approved first. By default, all first-time contributors require approval to run workflows.
|
@so99ynoodles |
templates/react-ts/src/main.tsx
Outdated
|
|
||
| ReactDOM.render( |
There was a problem hiding this comment.
Thank you for your suggestion.
We would like to avoid making multiple changes to a single pull request.
Could you create a separate pull request for React?
odanado
added
status: in progress
|
@shogo0421 Thank you for your work. Could you resolve the conflict before the review? |
.github/workflows/code-check.yml
Outdated
| - name: Install dependencies | ||
| run: yarn install --immutable --immutable-cache --check-cache | ||
| - name: Run lint | ||
| run: yarn run lint |
There was a problem hiding this comment.
| run: yarn run lint | |
| run: yarn run lint:eslint |
odanado
added
the
type: maintenance
Closes #16
feat: add ci/cd workflow
fix: update react template
✅ Pull Request Checklist:
📝 Test Instructions:
install both react/react-ts templates and see if there is no lint / ts error.