Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use setMinAssetsLockDuration on escrow initialize #256

Merged
merged 2 commits into from
Feb 4, 2025
Merged

feat: use setMinAssetsLockDuration on escrow initialize #256

merged 2 commits into from
Feb 4, 2025

Conversation

rkolpakov
Copy link
Contributor

No description provided.

@rkolpakov rkolpakov requested a review from Psirex January 31, 2025 12:22
@Psirex Psirex requested a review from sandstone-ag February 3, 2025 11:55
sandstone-ag
sandstone-ag approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@sandstone-ag sandstone-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Please take a look at the comments, there may be some minor points to improve (but we can postpone it of course).

contracts/libraries/EscrowState.sol Outdated Show resolved Hide resolved
test/unit/libraries/EscrowState.t.sol Show resolved Hide resolved
@Psirex
Copy link
Contributor

Psirex commented Feb 4, 2025

Also, please update the specification for the Escrow.initialize() method with the new requirement

@rkolpakov rkolpakov force-pushed the feat/escrow-initialize-min-assets-lock-duration branch from fc70f62 to d499671 Compare February 4, 2025 09:52
sandstone-ag
sandstone-ag approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@sandstone-ag sandstone-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rkolpakov rkolpakov force-pushed the feat/escrow-initialize-min-assets-lock-duration branch from d499671 to 35eeaf2 Compare February 4, 2025 12:04
@rkolpakov rkolpakov force-pushed the feat/escrow-initialize-min-assets-lock-duration branch from 35eeaf2 to 30015d3 Compare February 4, 2025 12:15
@Psirex Psirex merged commit b741221 into develop Feb 4, 2025
2 checks passed
@Psirex Psirex mentioned this pull request Feb 4, 2025
Merged
@sandstone-ag sandstone-ag deleted the feat/escrow-initialize-min-assets-lock-duration branch February 7, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Psirex Psirex Psirex approved these changes

@sandstone-ag sandstone-ag sandstone-ag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkolpakov @Psirex @sandstone-ag