Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.0.0-rc3 #267

Merged
merged 27 commits into from
Feb 4, 2025
Merged

1.0.0-rc3 #267

merged 27 commits into from
Feb 4, 2025

Conversation

Psirex
Copy link
Contributor

@Psirex Psirex commented Feb 4, 2025 •
edited
Loading

Release Notes

Code:

Docs:

Psirex and others added 27 commits January 31, 2025 16:58
@Psirex
Add validation for the second seal and eliminate the overflow risk in…
1b0980a 
… calcRageQuitWithdrawalsDelay
@rkolpakov
feat: handle properly empty unstETHIds array in markUnstETHFinalized
8337ce6
@rkolpakov
fix: dual governance config comment fix
ca3ea75
@rkolpakov
fix: timelocked governance add docstring return value
d03d9d1
@rkolpakov
fix: change IDualGovernance interface
d4fde93
@bulbozaur
checking for sealable is paused on tiebreaker proposal submission
99ae382
@bulbozaur
sealable zero address check
f3093cd
@Psirex
Merge pull request #262 from lidofinance/fix/incorrect-interfaces
2e4e01a 
Change IDualGovernance interface
@Psirex
Merge pull request #261 from lidofinance/fix/incomplete-docstrings-ti…
3692ea2 
…melocked-governance

Timelocked governance add docstring return value
@Psirex
Merge pull request #260 from lidofinance/fix/dual-governance-config-c…
68a9680 
…omment-fix

Dual governance config comment fix
@rkolpakov
fix: remove redundant getter from setProposerExecutor
f721d2f
@rkolpakov
fix: canceled wording
96567e7
@Psirex
Check minExecutionDelay has passed before proposal execution
dca6fb3
@Psirex
Update spec for DualGovernance.setConfigProvider
0a8ecd9
@Psirex
Update plan-b & tweak spec documents
ab8c459
@rkolpakov
fix: wording
c19a82b
@bulbozaur
documentation update
ff31ec0
@bulbozaur
spec update
b45ef4e
@Psirex
Merge pull request #265 from lidofinance/fix/canceled-wording
c5a270c 
Audit fix: wording
@Psirex
Merge pull request #264 from lidofinance/feature/tiebreaker-extra-check
b273969 
Extra check on tiebreaker proposal submission
@Psirex
Merge pull request #258 from lidofinance/feature/code-quality-improve…
bcd0ff6 
…ments

Code quality improvements
@rkolpakov
feat: use setMinAssetsLockDuration on escrow initialize
30015d3
@Psirex
Merge pull request #266 from lidofinance/feature/min-execution-delay-…
08c5dbc 
…check

Check `minExecutionDelay` has passed before proposal execution
@rkolpakov
fix: escrowState test fix
005955d
@Psirex
Merge pull request #256 from lidofinance/feat/escrow-initialize-min-a…
b741221 
…ssets-lock-duration

feat: use setMinAssetsLockDuration on escrow initialize
@Psirex
Comments and assume fixes for DualGovernanceConfig test
937699a
@Psirex
Merge pull request #257 from lidofinance/feature/dg-config-constraints
cc369df 
DualGovernanceConfig additional constraints
@Psirex Psirex changed the title 1.0.0-rc2 1.0.0-rc3 Feb 4, 2025
@Psirex Psirex requested a review from rkolpakov February 4, 2025 13:08
sandstone-ag
sandstone-ag approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@sandstone-ag sandstone-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Psirex Psirex merged commit a6a8c6e into main Feb 4, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulbozaur bulbozaur bulbozaur approved these changes

@rkolpakov rkolpakov rkolpakov approved these changes

@sandstone-ag sandstone-ag sandstone-ag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Psirex @bulbozaur @rkolpakov @sandstone-ag