Code

Statemind audit results#217

Code

Merged

bulbozaur merged 70 commits intodeveloplidofinance/dual-governance:developfrom audits/statemind-responseslidofinance/dual-governance:audits/statemind-responsesCopy head branch name to clipboardNov 29, 2024

+1,389-530

Commits

Commits on Nov 20, 2024

• remove TimelockedGovernance.executeProposal

  bulbozaur

  committed
  06d4b62

  Copy full SHA for 06d4b62

• reseal pause check fix

  bulbozaur

  committed
  b0c98e4

  Copy full SHA for b0c98e4

• HashConsensus historical data

  bulbozaur

  committed
  bf18ce8

  Copy full SHA for bf18ce8

• allow to schedule if quorum already reached

  bulbozaur

  committed
  1a47551

  Copy full SHA for 1a47551

• Additional submitted proposal eventdata

  bulbozaur

  committed
  e787026

  Copy full SHA for e787026

• fix natspec

  bulbozaur

  committed
  72c6136

  Copy full SHA for 72c6136

Commits on Nov 22, 2024

• Merge pull request #209 from lidofinance/develop

  Show description for 7f89246
  bulbozaur

  authored
  7f89246

  Copy full SHA for 7f89246

• Deny scheduling while zero quorum

  bulbozaur

  committed
  0a3c43e

  Copy full SHA for 0a3c43e

• remove requestWithdrawals method in the Escrow contract

  

  rkolpakov

  authored and

  bulbozaur

  committed
  525089b

  Copy full SHA for 525089b

• Merge pull request #186 from lidofinance/fix/remove-requestWithdrawals

  Show description for 8675143
  bulbozaur

  authored
  8675143

  Copy full SHA for 8675143

• detailed events for accountUnstETHFinalized

  bulbozaur

  committed
  1cf0d0a

  Copy full SHA for 1cf0d0a

• Merge branch 'audits/statemind-responses' into fix/remove-executeProposal

  bulbozaur

  authored
  9484a6b

  Copy full SHA for 9484a6b

• Merge branch 'audits/statemind-responses' into fix/hashConsensus

  bulbozaur

  committed
  baa7a49

  Copy full SHA for baa7a49

• use one slot for hash state

  bulbozaur

  committed
  803759a

  Copy full SHA for 803759a

• Merge branch 'audits/statemind-responses' into fix/submit-proposal-proposer

  bulbozaur

  authored
  97b3c78

  Copy full SHA for 97b3c78

• update spec

  bulbozaur

  committed
  9f74af5

  Copy full SHA for 9f74af5

• change ops order

  bulbozaur

  committed
  ae46713

  Copy full SHA for ae46713

• Merge branch 'audits/statemind-responses' into fix/incorect-natspec

  bulbozaur

  committed
  d26f2c3

  Copy full SHA for d26f2c3

Commits on Nov 26, 2024

• Missing constructor check for TiebreakerActivationTimeout

  bulbozaur

  committed
  70542a5

  Copy full SHA for 70542a5

• unregisterProposer gas optimization

  bulbozaur

  committed
  2d44940

  Copy full SHA for 2d44940

• Absence of zero check: unlockUnstETH reverts on empty ids

  bulbozaur

  committed
  f6f5433

  Copy full SHA for f6f5433

• remove unused methods

  bulbozaur

  committed
  b17faca

  Copy full SHA for b17faca

• gas optimization

  bulbozaur

  committed
  55f3ecd

  Copy full SHA for 55f3ecd

• add state check

  bulbozaur

  committed
  f30e2cf

  Copy full SHA for f30e2cf

• isWithdrawalsBatchesClosed naming

  bulbozaur

  committed
  339e469

  Copy full SHA for 339e469

• Missing parameter sanity checks: minAssetsLockDuration gt zero

  bulbozaur

  committed
  a299026

  Copy full SHA for a299026

• Add missing view Escrow.test_getVetoerUnstETHIds

  bulbozaur

  committed
  d96ebf7

  Copy full SHA for d96ebf7

• simplify proposal status checks in ExecutableProposals library

  bulbozaur

  committed
  c5bb59d

  Copy full SHA for c5bb59d

• Remove TiebreakerCoreCommittee nonce check

  bulbozaur

  committed
  6b6338c

  Copy full SHA for 6b6338c

• Add constructor checks for valid governance and timelock addresses

  bulbozaur

  committed
  821c379

  Copy full SHA for 821c379

• Timestamp.now optimization

  bulbozaur

  committed
  397938c

  Copy full SHA for 397938c

• rageQuitExtensionPeriodStartedAt as local var

  bulbozaur

  committed
  b02dfda

  Copy full SHA for b02dfda

• storage usage optimization

  bulbozaur

  committed
  494a70d

  Copy full SHA for 494a70d

• Timestamp type usage

  bulbozaur

  committed
  cc4f0e2

  Copy full SHA for cc4f0e2

• Merge pull request #181 from lidofinance/fix/tiebraker-init

  Show description for 40ca9e6
  bulbozaur

  authored
  40ca9e6

  Copy full SHA for 40ca9e6

• Merge pull request #203 from lidofinance/fix/pause-check

  Show description for c5e0359
  bulbozaur

  authored
  c5e0359

  Copy full SHA for c5e0359

Commits on Nov 27, 2024

• review fixes

  bulbozaur

  committed
  de2e6ef

  Copy full SHA for de2e6ef

• Merge pull request #202 from lidofinance/fix/remove-executeProposal

  Show description for 140175e
  bulbozaur

  authored
  140175e

  Copy full SHA for 140175e

• review fixes

  bulbozaur

  committed
  256239b

  Copy full SHA for 256239b

• unit tests

  bulbozaur

  committed
  a0fa7e9

  Copy full SHA for a0fa7e9

• refactor proposal status checks in ExecutableProposals

  bulbozaur

  committed
  34c1cf3

  Copy full SHA for 34c1cf3

• naming

  bulbozaur

  committed
  0202b5d

  Copy full SHA for 0202b5d

• review fixes

  bulbozaur

  committed
  dd7f80c

  Copy full SHA for dd7f80c

• using uint32 safely

  bulbozaur

  committed
  453d4db

  Copy full SHA for 453d4db

• restore test check

  bulbozaur

  committed
  d2c1506

  Copy full SHA for d2c1506

• restore TiebreakerCoreCommittee nonce check

  bulbozaur

  committed
  f896066

  Copy full SHA for f896066

• fix test value

  bulbozaur

  committed
  f1ee5a3

  Copy full SHA for f1ee5a3

• fix wrong check value type

  bulbozaur

  committed
  7301c0d

  Copy full SHA for 7301c0d

• Merge pull request #216 from lidofinance/audit-fix/redundant-proposal-status-check

  Show description for e9e31da
  bulbozaur

  authored
  e9e31da

  Copy full SHA for e9e31da

• Merge pull request #214 from lidofinance/fix/missing-getter

  Show description for 5678106
  bulbozaur

  authored
  5678106

  Copy full SHA for 5678106

• Merge pull request #212 from lidofinance/audit-fix/gas-optimizations

  Show description for 8e0aaa0
  bulbozaur

  authored
  8e0aaa0

  Copy full SHA for 8e0aaa0

• Merge pull request #211 from lidofinance/audit-fix/missing-checks

  Show description for c12b36c
  bulbozaur

  authored
  c12b36c

  Copy full SHA for c12b36c

• Merge pull request #208 from lidofinance/fix/incorect-natspec

  Show description for 83b4c3e
  bulbozaur

  authored
  83b4c3e

  Copy full SHA for 83b4c3e

• Merge pull request #205 from lidofinance/fix/submit-proposal-proposer

  Show description for 2b85627
  bulbozaur

  authored
  2b85627

  Copy full SHA for 2b85627

• Merge branch 'audits/statemind-responses' into audit-fix/WithdrawalsBatchesQueue-functions-improvements

  bulbozaur

  committed
  032455b

  Copy full SHA for 032455b

• Merge pull request #213 from lidofinance/audit-fix/WithdrawalsBatchesQueue-functions-improvements

  Show description for 140be7b
  bulbozaur

  authored
  140be7b

  Copy full SHA for 140be7b

• Merge pull request #190 from lidofinance/fix/revert-on-unsteth-state

  Show description for 0ce5711
  bulbozaur

  authored
  0ce5711

  Copy full SHA for 0ce5711

Commits on Nov 28, 2024

• refactor data types

  bulbozaur

  committed
  2b4c2dd

  Copy full SHA for 2b4c2dd

• timelockDuration getter

  bulbozaur

  committed
  fee88cf

  Copy full SHA for fee88cf

• functions order

  bulbozaur

  committed
  da0dca9

  Copy full SHA for da0dca9

• refactor setQuorum checks

  bulbozaur

  committed
  bcfc53d

  Copy full SHA for bcfc53d

• Merge branch 'audits/statemind-responses' into fix/hashConsensus

  bulbozaur

  authored
  48f49c1

  Copy full SHA for 48f49c1

• using uint256 for historical values

  bulbozaur

  committed
  9b8cf69

  Copy full SHA for 9b8cf69

• Fix the check in the addSealableWithdrawalBlocker()

  bulbozaur

  committed
  6e34653

  Copy full SHA for 6e34653

• Merge pull request #221 from lidofinance/fix/tiebraker-sealable-resumed-condition

  Show description for ecfa820
  bulbozaur

  authored
  ecfa820

  Copy full SHA for ecfa820

• Merge pull request #204 from lidofinance/fix/hashConsensus

  Show description for f0dc233
  bulbozaur

  authored
  f0dc233

  Copy full SHA for f0dc233

Commits on Nov 29, 2024

• Add EmergencyProtectedTimelock.MIN_EXECUTION_DELAY sanity check

  Psirex

  committed
  b754de5

  Copy full SHA for b754de5

• Improve EmergencyProtectedTimelock unit tests

  Psirex

  committed
  515254b

  Copy full SHA for 515254b

• Update plan-b and spec docs

  Psirex

  committed
  ba2809c

  Copy full SHA for ba2809c

• Merge pull request #223 from lidofinance/audit-fix/timelock-state-constraints

  Show description for 6328ec1
  Psirex

  authored
  6328ec1

  Copy full SHA for 6328ec1