Statemind audit results #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge develop into audits/statemind-responses
Audit fix: remove Escrow.requestWithdrawals()
…-status-check Audit fix: Check for proposal.status in ExecutableProposals._isProposalMarkedCancelled() is required only in one case
Add missing getter for vetoer locked unstETH Ids
Audit fix: Gas optimizations and code consistancy
Audit fix: Missing sanity checks
Audit fix: Incorrect natspec
Audit fix: Proposer is not saved proposal data
…atchesQueue-functions-improvements
…Queue-functions-improvements Audit fix: The WithdrawalsBatchesQueue functions improvements
Audit fix: Event emission for unfinalized records
…ed-condition Fix the check in the addSealableWithdrawalBlocker()
Audit fix: HashConsensus
…straints Audit Fix: Add `EmergencyProtectedTimelock.MIN_EXECUTION_DELAY()` sanity check
Psirex
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.