Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge :hasSeries into :partOfSeries #367

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
+9 −8
Draft

Merge :hasSeries into :partOfSeries #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions source/vocab/relations.ttl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,6 @@ prefix relsubtype: <http://id.loc.gov/vocabulary/preservation/relationshipSubTyp
rdfs:comment "Relaterad resurs vilken den beskrivna resursen är en fysisk eller logisk del av."@sv;
owl:equivalentProperty bf2:partOf, dc:isPartOf, sdo:isPartOf, relsubtype:isp . # TODO: super-properties of relsubtype:isp instead?

:partOfSeries a owl:ObjectProperty;
rdfs:subPropertyOf :isPartOf;
rdfs:label "part of series"@en, "del av serie"@sv .

:references a owl:ObjectProperty;
rdfs:label "hänvisar till"@sv;
owl:equivalentProperty dc:references .
Expand Down Expand Up @@ -424,11 +420,16 @@ prefix relsubtype: <http://id.loc.gov/vocabulary/preservation/relationshipSubTyp
rdfs:subPropertyOf :accompanies;
owl:inverseOf :supplement .

:hasSeries a owl:ObjectProperty;
rdfs:label "har serie"@sv;
:partOfSeries a owl:ObjectProperty;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.partOfSeries is missing the corresponding owl:inverseOf :seriesOf; which in turn probably is best to change from :hasSeries to :partOfSeries.

owl:sameAs :hasSeries;
rdfs:subPropertyOf :isPartOf;
sdo:domainIncludes :Creation ;
sdo:rangeIncludes :Creation ;
rdfs:label "part of series"@en, "del av serie"@sv ;
skos:altLabel "har serie"@sv;
rdfs:comment "Resurs i vilken delen har blivit utgiven; titel av den större resursen syns i delen."@sv;
owl:propertyChainAxiom ( :seriesMembership :inSeries ) ;
owl:equivalentProperty bf2:hasSeries .
owl:equivalentProperty bf2:hasSeries, sdo:partOfSeries .

:seriesOf a owl:ObjectProperty;
rdfs:label "Series container of"@en, "Ingående seriedel"@sv;
Expand All @@ -446,7 +447,7 @@ prefix relsubtype: <http://id.loc.gov/vocabulary/preservation/relationshipSubTyp
rdfs:domain :SeriesMembership ;
rdfs:subPropertyOf :object ;
sdo:rangeIncludes :Instance ;
rdfs:label "ingår i serie"@sv .
rdfs:label "medlemskap i serie"@sv .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change label here? for me it introduces a confusion with seriesMembership label.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It came from a note I had (from some chat IIRC) about differentiating inSeries and partOfSeries through its label. But if we don't need to I'll gladly revert this label, since when used its context (i.e. the type of the thing it's placed on (:SeriesMembership)) should make the simpler label obvious, and when listed the domain/range context is reasonably needed anyway.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. We should do a follow up on that note on any possible differences, and if so document that in a comment or scopenote at least.


:SeriesMembership a owl:Class ;
rdfs:subClassOf :PartitiveRelationship ;
Expand Down