-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge :hasSeries into :partOfSeries #367
base: develop
Are you sure you want to change the base?
Conversation
Also define domain and range and adjust labels.
@@ -446,7 +447,7 @@ prefix relsubtype: <http://id.loc.gov/vocabulary/preservation/relationshipSubTyp | |||
rdfs:domain :SeriesMembership ; | |||
rdfs:subPropertyOf :object ; | |||
sdo:rangeIncludes :Instance ; | |||
rdfs:label "ingår i serie"@sv . | |||
rdfs:label "medlemskap i serie"@sv . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change label here? for me it introduces a confusion with seriesMembership label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It came from a note I had (from some chat IIRC) about differentiating inSeries
and partOfSeries
through its label. But if we don't need to I'll gladly revert this label, since when used its context (i.e. the type of the thing it's placed on (:SeriesMembership
)) should make the simpler label obvious, and when listed the domain/range context is reasonably needed anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. We should do a follow up on that note on any possible differences, and if so document that in a comment or scopenote at least.
@@ -424,11 +420,16 @@ prefix relsubtype: <http://id.loc.gov/vocabulary/preservation/relationshipSubTyp | |||
rdfs:subPropertyOf :accompanies; | |||
owl:inverseOf :supplement . | |||
|
|||
:hasSeries a owl:ObjectProperty; | |||
rdfs:label "har serie"@sv; | |||
:partOfSeries a owl:ObjectProperty; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.partOfSeries
is missing the corresponding owl:inverseOf :seriesOf;
which in turn probably is best to change from :hasSeries
to :partOfSeries
.
Also define domain and range and adjust labels.