Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump MSRV to 1.73 #4692

Merged
merged 10 commits into from
Oct 24, 2023
Prev Previous commit
Next Next commit
Statically link interop-tests bin
thomaseizinger committed Oct 24, 2023
commit 4bed43921a2304e7aa4c20a9625fa4a27112fd6b
4 changes: 2 additions & 2 deletions interop-tests/Dockerfile.chromium
Original file line number Diff line number Diff line change
@@ -14,11 +14,11 @@ FROM chef AS builder
COPY --from=planner /app/recipe.json recipe.json
# Build dependencies - this is the caching Docker layer!
RUN cargo chef cook --release --package interop-tests --target wasm32-unknown-unknown --recipe-path recipe.json
RUN cargo chef cook --release --package interop-tests --bin wasm_ping --recipe-path recipe.json
RUN RUSTFLAGS='-C target-feature=+crt-static' cargo chef cook --release --package interop-tests --target x86_64-unknown-linux-gnu --bin wasm_ping --recipe-path recipe.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a short comment why this is needed? For future us to eventually go back to the provided glibc?

# Build application
COPY . .
RUN wasm-pack build --target web interop-tests
RUN cargo build --release --package interop-tests --bin wasm_ping
RUN RUSTFLAGS='-C target-feature=+crt-static' cargo build --release --package interop-tests --target x86_64-unknown-linux-gnu --bin wasm_ping

FROM selenium/standalone-chrome:115.0
COPY --from=builder /app/target/release/wasm_ping /usr/local/bin/testplan