chore: bump MSRV to 1.73 #4692
chore: bump MSRV to 1.73 #4692
Conversation
|
This pull request has merge conflicts. Could you please resolve them @thomaseizinger? 🙏 |
|
@mxinden I had to modify the interop-tests docker image to statically link glibc because the 1.73 image comes with a different version from what is within the chromium image. |
thomaseizinger
force-pushed
the
deps/bump-rust-1.75
branch
from
4d59954 to
b83c1a6
Compare
thomaseizinger
force-pushed
the
deps/bump-rust-1.75
branch
from
b83c1a6 to
8965f6d
Compare
| @@ -14,13 +14,13 @@ FROM chef AS builder | |||
| COPY --from=planner /app/recipe.json recipe.json | |||
| # Build dependencies - this is the caching Docker layer! | |||
| RUN cargo chef cook --release --package interop-tests --target wasm32-unknown-unknown --recipe-path recipe.json | |||
| RUN cargo chef cook --release --package interop-tests --bin wasm_ping --recipe-path recipe.json | |||
| RUN RUSTFLAGS='-C target-feature=+crt-static' cargo chef cook --release --package interop-tests --target x86_64-unknown-linux-gnu --bin wasm_ping --recipe-path recipe.json | |||
There was a problem hiding this comment.
Can you add a short comment why this is needed? For future us to eventually go back to the provided glibc?
|
We are using libp2p transitively through one of our deps, and this change requires us to bump our entire msrv to 1.73. I am trying to understand the motivation behind using latest stable as msrv - from the 3 listed newer rust features I believe once cell is the newest in 1.70. It's not a big issue for us (other than being a chore), but we are trying to be as loose as possible with msrv's. |
|
Personally, one of the more exciting features in Rust that I am looking forward to is async-fn-in-traits which will stabilize in 1.75. I'd like to bump to that with the next minor release. In regards to the |
To allow merging #5232 CC @SuperFluffy since you commented on #4692 Pull-Request: #5266.
Description
With the upcoming
v0.53release, I'd suggest we also bump the MSRV. This will allows to make use of new things like:let elsestd::pin::pin!OnceCellFor now, this PR doesn't make us of any of these. We can always ship them as internal improvements later and enforce certain things via lints (like
let else).Notes & open questions
Should we not bump to the latest version but something before that? Do we know of any users that might be constrained by MSRV requirements from updating?
Change checklist