Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.10 wheels #150

Merged
merged 15 commits into from
Dec 12, 2021
Merged

Python 3.10 wheels #150

merged 15 commits into from
Dec 12, 2021

Conversation

letmaik
Copy link
Owner

@letmaik letmaik commented Oct 7, 2021

CI is still failing since scikit-image (test dependency) has no Python 3.10 wheels yet. Once wheels are available, this PR can be picked up again and CI re-run.

Also in here:

  • Use vcpkg for native dependencies on Windows instead of conda
  • LCMS color engine and RedCine codec support on Windows
  • Use pip instead of conda for Python dependencies on Windows
  • Drop Python 3.6 wheel support

@occamz
Copy link
Contributor

occamz commented Nov 8, 2021

Hello, I was interested in the status of this so I forked the repository and ran the CI of this branch: https://github.com/boksidev/rawpy/actions/runs/1436776781

At least the macOS issue seems to be resolved with the latest numpy release: https://github.com/numpy/numpy/releases/tag/v1.21.4

For some reason all of the Windows builds failed, not really sure what to make of it as I have close to no python experience in a Windows environment...


Ignoring that, I guess the next problem in line is that nose (which seems to be unmaintained) is failing with:

AttributeError: module 'collections' has no attribute 'Callable'

This is due to the deprecated aliases to Collections Abstract Base Classes being removed from the collections module in 3.10: https://docs.python.org/3/whatsnew/3.10.html#removed
Related comment: minio/minio-py#942


I replaced nose with nose-py3, which advertises itself as a nose drop-in replacement. It seems to fix that issue: https://github.com/boksidev/rawpy/actions/runs/1436947790

Might still be worth considering a switch to pytest or nose2 instead.


Any clue on why the Windows builds are failing on my end?

@letmaik
Copy link
Owner Author

letmaik commented Nov 9, 2021

@occamz Thanks for giving this a try. Regarding nose, I opened #156. Are you interested in making a contribution to switch to pytest? That would be very helpful! Regarding Windows, that must be some temporary conda mishap and will probably auto-resolve itself soon... I can't decipher what exactly the problem is, but it's not the first time some package dependencies are messed up in the conda repository.
EDIT: Opened an upstream issue for that: ContinuumIO/anaconda-issues#12717

@occamz
Copy link
Contributor

occamz commented Nov 9, 2021

@letmaik I took a stab at it and submitted PR #157


Windows / Conda still failing: https://github.com/boksidev/rawpy/actions/runs/1440214710
For macOS / Ubuntu the tests seem to pass and the build completes.

@letmaik
Copy link
Owner Author

letmaik commented Nov 21, 2021

@occamz I removed reliance on conda for dependencies since it was getting ridiculous... However, scikit-image still hasn't published wheels for Python 3.10 which is the last remaining blocker.

@occamz
Copy link
Contributor

occamz commented Nov 23, 2021

@letmaik All right, thanks for your efforts and the update on the situation!

Seems like scikit-image has already merged changes to include 3.10 in their wheel build in this PR: scikit-image/scikit-image#6021. So if I understand this correctly, we need to wait for them to publish a new version - which would run their new build that would produce the 3.10 wheels.

@kmilos kmilos mentioned this pull request Nov 26, 2021
@letmaik letmaik merged commit 32de843 into master Dec 12, 2021
@letmaik letmaik deleted the py310 branch December 12, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants