Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Jasper for Windows build #104

Closed
wants to merge 2 commits into from
Closed

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Mar 31, 2020

Addresses #103

@letmaik
Copy link
Owner

letmaik commented Mar 31, 2020

Thanks for this. I had a look at the Windows CI failure ("DLL load failed: The specified module could not be found."), and this is because libjasper on conda-forge is only published as shared library, not as statically linked library. The issue can theoretically be fixed by copying the DLL to the right folder, but... unfortunately shared libraries have caused me/rawpy way too much pain in the past for Windows so I made the decision to only link against static libraries for Windows. Both libjpeg and zlib are available as static libraries on conda. Could you change the conda-forge repo to also build the statically linked library of libjasper for Windows? Then we can continue here.

@kmilos
Copy link
Contributor Author

kmilos commented Mar 31, 2020

Yes, figured that was the problem... For Anaconda users dynamic linking should be ok, but I guess you want to cover a wider base. Requested at conda-forge, let's see...

@letmaik
Copy link
Owner

letmaik commented Nov 21, 2021

This PR won't be necessary anymore as I moved away from conda for dependencies and instead use vcpkg. See #150.

@kmilos
Copy link
Contributor Author

kmilos commented Nov 22, 2021

Ok, makes sense to switch.

@kmilos kmilos closed this Nov 22, 2021
@kmilos kmilos deleted the patch-1 branch November 22, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants