Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace netifaces with ifaddr #1151

Closed
achimnol opened this issue Mar 10, 2023 · 0 comments · Fixed by #1155
Closed

Replace netifaces with ifaddr #1151

achimnol opened this issue Mar 10, 2023 · 0 comments · Fixed by #1155
Labels
area:upstream Issues with root cause from upstream 3rd parties comp:agent Related to Agent component comp:common Related to Common component effort:easy Need to understand only a specific region of codes (good first issue, easy). type:enhance Enhance component, behavior, internals without user-facing features
Milestone
22.09

Comments

@achimnol
Copy link
Member

achimnol commented Mar 10, 2023 •
edited
Loading

netifaces is no longer maintained and does not provide official wheels for Python 3.10+.
There is a fork called netifaces-plus but its author recommends ifaddr as a replacement.

Since we just need to enumerate network interfaces and their IP addresses, ifaddr's functionality is sufficient for us. Moreover, it is based on a pure Python implementation, making the installation on customer sites much easier.

Let's replace netifaces with ifaddr.
@achimnol achimnol added comp:agent Related to Agent component comp:common Related to Common component area:upstream Issues with root cause from upstream 3rd parties type:enhance Enhance component, behavior, internals without user-facing features labels Mar 10, 2023
@achimnol achimnol added this to the 22.09 milestone Mar 10, 2023
@achimnol achimnol added the effort:easy Need to understand only a specific region of codes (good first issue, easy). label Mar 10, 2023
@achimnol achimnol mentioned this issue Mar 10, 2023
Merged
@achimnol achimnol mentioned this issue Mar 10, 2023
Closed
@retsyo retsyo mentioned this issue Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:upstream Issues with root cause from upstream 3rd parties comp:agent Related to Agent component comp:common Related to Common component effort:easy Need to understand only a specific region of codes (good first issue, easy). type:enhance Enhance component, behavior, internals without user-facing features
Projects
None yet
Milestone
22.09
Development

Successfully merging a pull request may close this issue.

deps: Replace netifaces with ifaddr lablup/backend.ai
1 participant
@achimnol