Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Replace netifaces with ifaddr #1155

Merged
merged 4 commits into from
Mar 10, 2023
Merged

deps: Replace netifaces with ifaddr #1155

merged 4 commits into from
Mar 10, 2023

Conversation

achimnol
Copy link
Member

resolves #1151

@achimnol achimnol added this to the 22.09 milestone Mar 10, 2023
@achimnol achimnol added area:upstream Issues with root cause from upstream 3rd parties type:enhance Enhance component, behavior, internals without user-facing features labels Mar 10, 2023
@github-actions github-actions bot added comp:agent Related to Agent component comp:common Related to Common component effort:easy Need to understand only a specific region of codes (good first issue, easy). labels Mar 10, 2023
@achimnol achimnol added this pull request to the merge queue Mar 10, 2023
@achimnol achimnol closed this Mar 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a manual request Mar 10, 2023
@achimnol achimnol deleted the feature/replace-netifaces-with-ifaddr branch March 10, 2023 09:43
@achimnol achimnol restored the feature/replace-netifaces-with-ifaddr branch March 10, 2023 09:43
@achimnol achimnol reopened this Mar 10, 2023
@achimnol
Copy link
Member Author

It works like:

> ./py
Python 3.11.2 (main, Feb  9 2023, 06:13:16) [GCC 11.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from ai.backend.common import identity
>>> from ipaddress import ip_network
>>> [*identity.fetch_local_ipaddrs(ip_network("0.0.0.0/0"))]
[IPv4Address('127.0.0.1'), IPv4Address('192.168.64.7'), IPv4Address('172.17.0.1'), IPv4Address('192.168.128.1'), IPv4Address('172.18.0.1')]
>>> [*identity.fetch_local_ipaddrs(ip_network("172.17.0.0/16"))]
[IPv4Address('172.17.0.1')]
>>>

@achimnol achimnol added this pull request to the merge queue Mar 10, 2023
Merged via the queue into main with commit e352e8f Mar 10, 2023
@achimnol achimnol deleted the feature/replace-netifaces-with-ifaddr branch March 10, 2023 09:47
achimnol added a commit that referenced this pull request Mar 10, 2023
@achimnol
deps: Replace netifaces with ifaddr (#1155)
2c397a9 
Backported-from: main
Backported-to: 22.09
@Yaminyam Yaminyam added the size:L 100~500 LoC label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@achimnol achimnol

Labels
area:upstream Issues with root cause from upstream 3rd parties comp:agent Related to Agent component comp:common Related to Common component effort:easy Need to understand only a specific region of codes (good first issue, easy). size:L 100~500 LoC type:enhance Enhance component, behavior, internals without user-facing features
Projects
None yet
Milestone
22.09
Development

Successfully merging this pull request may close these issues.

Replace netifaces with ifaddr
2 participants
@achimnol @Yaminyam