Make netifaces dependency optional
#1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because it is not easy to install on all systems
falkoschindler
approved these changes
Jul 14, 2023
|
netifaces is al45tair/netifaces#78 and does not provide official wheels for Python 3.10+. |
|
Oh cool. Thanks for the pointer to ifaddr @retsyo. Looks promising. We will have a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the
netifacespackage for convince to present a list of IPs through which the NiceGUI website is available. Butnetifacesis not available as wheel for all platforms and therefore requires gcc and similar tools to be installed. This is especially annoying in Docker containers which should be kept small. Because we do not want to force users to do multi-stage builds this pull request makes the package optional.