chore: UpwardLinkのstyle生成をmemo化する #5244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtsushiM
commented
Jan 9, 2025
commit: |
yagimushi
force-pushed
the
chore-memoized-upward-link
branch
from
951dea9 to
46fa1d6
Compare
yagimushi
force-pushed
the
chore-memoized-upward-link
branch
from
46fa1d6 to
a3816cc
Compare
AtsushiM
requested review from
misako0927 and
hiroki0525
and removed request for
a team
AtsushiM
commented
Jan 10, 2025
| import { VariantProps, tv } from 'tailwind-variants' | ||
|
|
||
| import { FaArrowLeftIcon } from '../Icon' | ||
| import { TextLink } from '../TextLink' | ||
|
|
||
| const upwardLink = tv({ | ||
| const styleGenerator = tv({ |
There was a problem hiding this comment.
[要モミ]
lintで tvで生成する変数の名称を統一する という意図が有るので /(S|s)tyleGenerator$/ にマッチする名称に変更しています。
この名称アタリ違和感ないでしょうか？
AtsushiM
commented
Jan 10, 2025
| /** `TextLink`に渡す `elementAs` をオプションで指定 */ | ||
| elementAs?: ComponentProps<typeof TextLink>['elementAs'] | ||
| } | ||
|
|
||
| export const UpwardLink: React.FC<Props> = ({ indent = true, className, elementAs, ...rest }) => { | ||
| const style = upwardLink({ indent, className }) | ||
| const style = useMemo(() => styleGenerator({ indent, className }), [indent, className]) |
There was a problem hiding this comment.
smarthr-ui内で記法がブレているため、style関連の生成をuseMemoでラップするよう統一します
oti
approved these changes
Jan 16, 2025
Qs-F
approved these changes
Jan 20, 2025
| import { VariantProps, tv } from 'tailwind-variants' | ||
|
|
||
| import { FaArrowLeftIcon } from '../Icon' | ||
| import { TextLink } from '../TextLink' | ||
|
|
||
| const upwardLink = tv({ | ||
| const styleGenerator = tv({ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法