fix!: FloatAreaのresponseMessage属性の型を実装に合わせて調整する #5299
+12
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
AtsushiM
commented
Jan 17, 2025
| }), | ||
| [style, zIndex], | ||
| ) | ||
| const styleAttr = useMemo(() => ({ ...style, zIndex }), [style, zIndex]) |
There was a problem hiding this comment.
object化して再展開していますが、内部に属性がstyleのみだったため、あまり意味がありませんでした。
style={hoge} 形式で指定させることにして調整しました
There was a problem hiding this comment.
↑、あそういう意味ではなくて、設定する属性はstyle属性のみで { style: hoge } のようなオブジェクトでmemo化する意味が薄い、という話でした。
もともとの処理としては {...styleProps} の ような方法で
- 中身のキーは一つなので混乱するだけで意味が薄い
- オブジェクトの展開分コストが無駄
という感じです。
There was a problem hiding this comment.
AtsushiM
commented
Jan 17, 2025
| > | ||
| <Cluster gap={1}> | ||
| {tertiaryButton} | ||
| <div className="shr-ms-auto"> | ||
| <Cluster gap={1} align="center"> | ||
| {(responseMessage?.status === 'success' || responseMessage?.status === 'error') && ( |
There was a problem hiding this comment.
statusがsuccess, errorのもののみに絞っていますが
- processingなresponseMessageが表示されない
- 理由もわからない
という感じなのでそもそも型として受け取れないように調整しました
これにより、チェックロジックもシンプルに変更できます
AtsushiM
changed the title
AtsushiM
requested review from
misako0927 and
masa0527
and removed request for
a team
uknmr
reviewed
Jan 19, 2025
| }), | ||
| [style, zIndex], | ||
| ) | ||
| const styleAttr = useMemo(() => ({ ...style, zIndex }), [style, zIndex]) |
…e-refactoring-FloatArea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法