Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable primary tool bar with toolbarOptions #163

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

SajidAlamQB
Copy link
Contributor

@SajidAlamQB SajidAlamQB commented Dec 11, 2024

Description

Related to: #156

For now we will enable the toolbar but keep the collapse/expand pipeline button disabled as it doesn't work interactively and needs further investigation.

The absence of a collapse feature affects users working with intricate pipelines, making it challenging to focus on specific sections. Implementing a collapse functionality would enhance usability by allowing users to manage pipeline visibility effectively, thereby improving workflow efficiency.

Introduce a collapse/expand toggle directly within the flowchart view, enabling users to control the visibility of individual pipeline sections by passing relevant props for Kedro-Viz react component in VSCode.

Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB
Copy link
Contributor Author

This PR needs: kedro-org/kedro-viz#2225, this PR is needed for the VSCode extension integration with Kedro Viz so that toggling the Expand/Collapse Pipelines button in the Kedro Viz webview panel instantly updates the displayed pipelines without requiring a manual refresh or data re-fetch. Previously, the expansion state would only take effect after reloading the panel or re-running Kedro Viz.

@SajidAlamQB SajidAlamQB marked this pull request as ready for review January 13, 2025 10:53
@SajidAlamQB
Copy link
Contributor Author

The expand and collapse button will remain disabled for now in the toolbarOptions until a fix is found. Even after the refactor in kedro-org/kedro-viz#2225 its still not functional within the the extension. In order to stop blocking the filter work this PR will leave the toolbar visible but disable the collapse and expand button.

@SajidAlamQB SajidAlamQB changed the title Collapse/Expand namespace pipeline with button Enable primary tool bar with toolbarOptions Jan 17, 2025
Copy link

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!

@astrojuanlu
Copy link
Member

Do you mind adding a before/after screenshot?

@@ -8,6 +8,13 @@ function App() {
const [error, setError] = React.useState(false);
const [loading, setLoading] = React.useState(true);

const toolbarOptions = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @SajidAlamQB this looks like it should be inside a config or something similar if we have one in the vscode?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we do, most of the viz options and settings are found in this file for the extension.

@SajidAlamQB
Copy link
Contributor Author

Before:
image

After:
image

@SajidAlamQB SajidAlamQB requested a review from Huongg January 22, 2025 14:52
Copy link

@Huongg Huongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @SajidAlamQB, LGTM 👍

@SajidAlamQB SajidAlamQB merged commit 8f02004 into main Jan 23, 2025
2 checks passed
@SajidAlamQB SajidAlamQB deleted the expand-and-collapse-pipeline-namespace branch January 23, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants