Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse/Expand namespace pipeline with button #156

Open
1 task
jitu5 opened this issue Nov 19, 2024 · 2 comments
Open
1 task

Collapse/Expand namespace pipeline with button #156

jitu5 opened this issue Nov 19, 2024 · 2 comments
Assignees
Labels
feature Improvement of existing feature or new feature javascript Pull requests that update Javascript code Kedro-Viz Functionality/Fix needs to done from Kedro-Viz

Comments

@jitu5
Copy link
Contributor

jitu5 commented Nov 19, 2024

Description

Currently, in the Kedro VSCode extension, users can expand pipelines but lack the ability to collapse them. This limitation hinders efficient navigation and management of complex pipelines within the flowchart view.

vscode-viz-sidebar

Context

The absence of a collapse feature affects users working with intricate pipelines, making it challenging to focus on specific sections. Implementing a collapse functionality would enhance usability by allowing users to manage pipeline visibility effectively, thereby improving workflow efficiency.

Possible Implementation

Introduce a collapse/expand toggle directly within the flowchart view, enabling users to control the visibility of individual pipeline sections by passing relevant props for Kedro-Viz react component in VSCode.

Acceptance Criteria

  • Users can see a toggle button/icon to collapse or expand individual pipeline sections.
  • Clicking the toggle button collapses the selected pipeline section and hides its nodes.
  • Clicking the toggle button again expands the pipeline section, revealing the previously hidden nodes.

Checklist

  • Include labels so that we can categorise your feature request
@jitu5 jitu5 added feature Improvement of existing feature or new feature javascript Pull requests that update Javascript code Kedro-Viz Functionality/Fix needs to done from Kedro-Viz labels Nov 19, 2024
@rashidakanchwala
Copy link

The figma design for this ticket are here - Designs can be found here - https://www.figma.com/design/3kSpvIO1veLKfy9qHxuXwF/Kedro-WIP?node-id=2936-125807&t=Km8oiXjUlRyVBUMk-4

In our React component, we need to introduce a new dictionary called toolbar to manage toolbarOptions. This will enable or disable the primary toolbar and its options.

For example, in the VS Code extension, we will need to disable the export option in the primary toolbar.

@rashidakanchwala rashidakanchwala moved this to Backlog in Kedro-Viz Nov 25, 2024
@SajidAlamQB SajidAlamQB moved this from Backlog to Todo in Kedro-Viz Nov 27, 2024
@SajidAlamQB SajidAlamQB moved this from Todo to In Progress in Kedro-Viz Nov 28, 2024
@SajidAlamQB SajidAlamQB moved this from In Progress to Todo in Kedro-Viz Dec 2, 2024
@Huongg Huongg moved this from Todo to In Progress in Kedro-Viz Dec 9, 2024
@SajidAlamQB SajidAlamQB moved this from In Progress to In Review in Kedro-Viz Dec 19, 2024
@rashidakanchwala rashidakanchwala moved this from In Review to In Progress in Kedro-Viz Jan 9, 2025
@Huongg Huongg moved this from In Progress to In Review in Kedro-Viz Jan 13, 2025
@SajidAlamQB SajidAlamQB moved this from In Review to In Progress in Kedro-Viz Jan 13, 2025
@SajidAlamQB
Copy link
Contributor

SajidAlamQB commented Jan 15, 2025

The expand and collapse button will remain disabled for now in the toolbarOptions until a fix is found. Even after the refactor in kedro-org/kedro-viz#2225 its still not functional within the the extension. In order to stop blocking the filter work this PR will leave the toolbar visible but disable the collapse and expand button. I've opened a new issue to track this: #165

@SajidAlamQB SajidAlamQB moved this from In Progress to In Review in Kedro-Viz Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Improvement of existing feature or new feature javascript Pull requests that update Javascript code Kedro-Viz Functionality/Fix needs to done from Kedro-Viz
Projects
Status: No status
Status: In Review
Development

No branches or pull requests

4 participants