Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numpy 2.0 e2e test fail with lower requirements #1949

Merged
merged 23 commits into from
Jun 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
0e7f24d
merge main from remote
ravi-kumar-pilla Apr 25, 2024
c1aae75
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Apr 26, 2024
177ccbc
merging remote
ravi-kumar-pilla May 1, 2024
8ecf9bf
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla May 2, 2024
37f3bf4
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla May 8, 2024
499d8c4
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla May 14, 2024
b3ab479
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla May 16, 2024
e295e92
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla May 20, 2024
905b198
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla May 21, 2024
490a89f
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla May 30, 2024
c1a099b
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla May 31, 2024
573e3c0
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Jun 10, 2024
5a12c65
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Jun 13, 2024
960c113
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
ravi-kumar-pilla Jun 18, 2024
3fe6026
pin numpy for lower_requirements
ravi-kumar-pilla Jun 18, 2024
58a1d0b
fix file permissions
ravi-kumar-pilla Jun 18, 2024
fb7f1ab
update release note
ravi-kumar-pilla Jun 18, 2024
3c886ee
testing 3.9 e2e test fail
ravi-kumar-pilla Jun 18, 2024
e72944f
pin numpy in requirements
ravi-kumar-pilla Jun 18, 2024
8f9f549
pin numpy during e2e test
ravi-kumar-pilla Jun 20, 2024
bf313d4
address PR comments1
ravi-kumar-pilla Jun 20, 2024
1dd04f2
overkill
ravi-kumar-pilla Jun 20, 2024
58a074d
add sphinx doc build fix
ravi-kumar-pilla Jun 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,9 @@ Please follow the established format:
# Release 9.2.0

## Major features and improvements

- Enable/disable preview for all the datasets when publishing Kedro-Viz from CLI. (#1894)
- Enable/disable preview for all the datasets when publishing Kedro-Viz from UI. (#1895)

## Bug fixes and other changes

## Major features and improvements
- Display published URLs. (#1907)

## Bug fixes and other changes
Expand Down
2 changes: 1 addition & 1 deletion docs/source/publish_and_share_kedro_viz_on_azure.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ The process of uploading your site's files will be done through Kedro-Viz.

3. Obtain parameters: In the app registration's overview pane, note down the Application (Client) ID and Directory (Tenant) ID.

4. Add client secret: Create a [client secret](https://learn.microsoft.com/en-us/entra/identity-platform/quickstart-register-app#add-a-client-secret)
4. Add client secret: Create a [client secret](https://learn.microsoft.com/en-us/entra/identity-platform/quickstart-register-app?tabs=client-secret#add-credentials)
for the app registration.

5. Assign IAM role: Assign an [Access Control (IAM) role](https://learn.microsoft.com/en-us/azure/role-based-access-control/role-assignments-portal?tabs=delegate-condition) to the storage account.
Expand Down
14 changes: 14 additions & 0 deletions package/features/steps/cli_steps.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,17 @@ def _create_config_file(context, include_example):
yaml.dump(config, config_file, default_flow_style=False)


def _add_package_pin(requirements_path: str, package_name: str, version: str) -> None:
"""Adds a package pin to the requirements file"""
with open(requirements_path, "r") as req_file:
requirements = req_file.readlines()

requirements.append(f"{package_name}=={version}")

with open(requirements_path, "w") as req_file:
req_file.writelines(requirements)


@given("I have prepared a config file with example code")
def create_config_file_with_example(context):
"""Behave step to create a temporary config file
Expand Down Expand Up @@ -80,6 +91,9 @@ def install_project_requirements(context):
"""Run ``pip install -r requirements.txt``."""
if context.kedro_version != "latest":
requirements_path = str(context.root_project_dir) + "/src/requirements.txt"
# numpy 2.0 breaks with old versions of pandas and this
# could be removed when the lowest version supported is updated
_add_package_pin(requirements_path, "numpy", "1.26.4")
else:
requirements_path = str(context.root_project_dir) + "/requirements.txt"

Expand Down
3 changes: 3 additions & 0 deletions package/features/steps/lower_requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,6 @@ strawberry-graphql==0.192.0
networkx==2.5
orjson==3.9
secure==0.3.0
# numpy 2.0 breaks with old versions of pandas and this
# could be removed when the lowest version supported is updated
numpy==1.26.4
ravi-kumar-pilla marked this conversation as resolved.
Show resolved Hide resolved
Loading