-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix numpy 2.0 e2e test fail with lower requirements #1949
Conversation
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Hi Team, I am trying to fix e2e test failures on kedro-viz. For both the cases below, pinning https://github.com/kedro-org/kedro-viz/actions/runs/9548599222/job/26316144191?pr=1935 NOTE: Kedro-Viz itself does not use numpy but seems like pandas uses numpy. Compatibility matrix mentioned here might help. Thank you |
It makes sense to cap But why does it need to be pinned in |
Hi @ankatiyar , Thank you for looking over the PR. This is not related to any new commit. Our builds were failing all of a sudden without any code change (even the old builds if re-run are failing). The e2e test that fails now is for the below scenario -
It might be some issue with the Thank you |
Okay I created a project with 0.18.3 and tried it and I see what is happening - I don't think anything of Kedro side is breaking since we run our tests only with the latest versions of |
Signed-off-by: ravi-kumar-pilla <[email protected]>
package/features/steps/cli_steps.py
Outdated
@@ -80,6 +80,15 @@ def install_project_requirements(context): | |||
"""Run ``pip install -r requirements.txt``.""" | |||
if context.kedro_version != "latest": | |||
requirements_path = str(context.root_project_dir) + "/src/requirements.txt" | |||
|
|||
with open(requirements_path, "r") as req_file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also add a comment here that this is because numpy 2.0
breaks with old versions of pandas
and this could be removed when the lowest version supported is updated
RELEASE.md
Outdated
- Display published URLs. (#1907) | ||
|
||
## Bug fixes and other changes | ||
|
||
- Fix numpy 2.0 e2e test fail with lower requirements. (#1949) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't need to be in the release notes I think as it's not a user facing change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure on this. We do mention changes in the - ## Bug fixes and other changes section which are not user facing (like - - Migrate from CircleCi to GitHub Actions. (#1876)). But will remove it for this PR. Need to know what to mention in this section of the release note.
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @ravi-kumar-pilla, looking good
Description
Resolves https://github.com/kedro-org/kedro-viz/actions/runs/9548598519/job/26316143362?pr=1935
Development notes
package/features/steps/lower_requirements.txt
at1.26.4
package/features/steps/cli_steps.py
at1.26.4
docs/source/publish_and_share_kedro_viz_on_azure.md
QA notes
Checklist
RELEASE.md
file