Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: [Regions] scroll container when dragging a region #3424

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

katspaugh
Copy link
Owner

Short description

Resolves #3244

Implementation details

When a region is dragged past the edge of a scrollable container, scroll the container accordingly.

Copy link
Contributor

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 70dee34
Status: ✅  Deploy successful!
Preview URL: https://f3056b50.wavesurfer-js.pages.dev
Branch Preview URL: https://scroll-region.wavesurfer-js.pages.dev

View logs

@katspaugh katspaugh merged commit 037b26b into main Dec 18, 2023
4 checks passed
@katspaugh katspaugh deleted the scroll-region branch December 18, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll waveform when dragging a region past the edge
1 participant