Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting region size while zoomed on part of region cause major render issues #3494

Closed
brian-byassee opened this issue Jan 16, 2024 · 1 comment · Fixed by #3496
Closed

Comments

@brian-byassee
Copy link
Contributor

Bug description

When the wavesurfer is zoomed in on a region so part of the region is off screen. If the user grabs the visible end of the wavesurfer and starts to drag there is major rendering issues. Please see attached video for example. (It can be reproduced here wavesrufer regions example

Wavesurfer_Issue.mov

The bug was introduced with this pull request
adjustScroll is being called for any region update not just when the region is being dragged.

One possible solution might be to add the side to the update event and only run adjustScroll when it is the region being dragged (undefinded) not the start or end

Environment

  • Browser: Chrome

Minimal code snippet

Expected result

The region size is able to be adjusted with out render issues.

Obtained result

It is impossible to adjust the size of the region in this case.

Screenshots

@katspaugh
Copy link
Owner

Good catch, thank you! Adding a side parameter is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants