Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compatability between TimelinePlugin and RegionsPlugin #3363

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/plugins/regions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -509,8 +509,8 @@ class RegionsPlugin extends BasePlugin<RegionsPluginEvents, RegionsPluginOptions
* Returns a function to disable the drag selection.
*/
public enableDragSelection(options: Omit<RegionParams, 'start' | 'end'>): () => void {
const wrapper = this.wavesurfer?.getWrapper()?.querySelector('div')
if (!wrapper) return () => undefined
const wrapper = this.wavesurfer?.getWrapper()?.querySelector('div.canvases')
if (!wrapper || !(wrapper instanceof HTMLElement)) return () => undefined

const initialSize = 5
let region: Region | null = null
Expand Down
1 change: 1 addition & 0 deletions src/plugins/timeline.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ class TimelinePlugin extends BasePlugin<TimelinePluginEvents, TimelinePluginOpti
private initTimelineWrapper(): HTMLElement {
const div = document.createElement('div')
div.setAttribute('part', 'timeline')
div.setAttribute('style', 'pointer-events: none;')
return div
}

Expand Down