Ensure compatability between TimelinePlugin and RegionsPlugin #3363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few sensible changes to ensure safe interaction between the TimelinePlugin and RegionsPlugin in the DOM.
Short description
Resolves #3293
Implementation details
TimelinePlugin wrapper element has
pointer-events: none;
to ensure mouse interaction with other elements above or below the timeline. The RegionsPlugin targets thecanvases
div inthis.wavesurfer.getWrapper()
as the draggable target to avoid unexpectedly targeting an incorrect div.How to test it
Dragging anywhere on the canvas, including over the timeline, should create a region.
Screenshots
Checklist