-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature webarkitrackers #4
Conversation
I recently merged a PR webarkit/webarkit-testing#8 within i released the first raw example. So we can say that the code in this branch https://github.com/kalwalt/WebARKitLib/tree/feature-webarkitrackers-pointers is working as expected. |
with virtual methods to be overriden - for now only WebARKitOrbTracker is a derived class
of WebARKitAkazeTracker class
i have created the new WebARKitTracker class, it seems that is correct; I will remove emscripten code from it. I think that is not necessary, better to mantain free from emscripten includes. |
I did all the planned changes, i think it is time to move on. I will transfer the code in the original repository and i will close this PR as said. |
- copyTo() instead of clone(): should be faster... - free(frameData)
I migrated the code so i can close this. For more infos see webarkit/webarkit-testing#15 |
I will not merge this in the
dev
branch it will serve only as a reminder.I am testing this code for WebARKit; there are a lot of unwanted commits (my fault) that i don't want to merge. But i think this will be useful as a reference.
Classes
First this is the folder structure:
Inside
include
:Inside
lib/SRC
:As you can see there are two main classes WebARKitAkazeTracker and WebARKitOrbTracker
There are very similar but one use Akaze and the last Orb.
All the WebARKit classes are included in the
webarkit
namespace.This the base code for https://github.com/kalwalt/webarkit-testing in detail see PR:
webarkit/webarkit-testing#4
webarkit/webarkit-testing#7
The code si heavily inspired by https://github.com/EdwardLu2018/wasm-ar
Features to add
webarkit
namespace