Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature webarkitrackers #4

Closed
wants to merge 79 commits into from
Closed

Conversation

kalwalt
Copy link
Owner

@kalwalt kalwalt commented Mar 28, 2023

I will not merge this in the dev branch it will serve only as a reminder.
I am testing this code for WebARKit; there are a lot of unwanted commits (my fault) that i don't want to merge. But i think this will be useful as a reference.

Classes

First this is the folder structure:
Inside include:

  • WebARKitTrackers
    • WebARKitOpticalTracking
      • WebARKitAkazeTracker.h
      • WebARKitConfig.h
      • WebARKitEnums.h
      • WebARKitOrbTracker.h
      • WebARKitUtils.h

Inside lib/SRC:

  • WebARKitTrackers
    • WebARKitOpticalTracking
      • WebARKitAkazeTracker.cpp
      • WebARKitConfig.cpp
      • WebARKitOrbTracker.cpp

As you can see there are two main classes WebARKitAkazeTracker and WebARKitOrbTracker
There are very similar but one use Akaze and the last Orb.
All the WebARKit classes are included in the webarkit namespace.
This the base code for https://github.com/kalwalt/webarkit-testing in detail see PR:
webarkit/webarkit-testing#4
webarkit/webarkit-testing#7
The code si heavily inspired by https://github.com/EdwardLu2018/wasm-ar

Features to add

  • create abstract class WebARKitTracker so WebARKitAkazeTracker and WebARKitOrbTracker will be derived from.
  • removing emscripten code from WebARKit*Tracker classes.
  • add other usfeful common methods.
  • webarkit namespace

@kalwalt kalwalt added the documentation Improvements or additions to documentation label Mar 28, 2023
@kalwalt
Copy link
Owner Author

kalwalt commented Apr 6, 2023

I recently merged a PR webarkit/webarkit-testing#8 within i released the first raw example. So we can say that the code in this branch https://github.com/kalwalt/WebARKitLib/tree/feature-webarkitrackers-pointers is working as expected.
I think that finally i can move to create a branch on WebARKitLib to host this code. I don't want to send a PR from this branch because there are a lot of 'tedious-unwanted' commits.
So i can think also to clean the code a bit and maybe rethinking some parts of it.

@kalwalt kalwalt self-assigned this Apr 6, 2023
kalwalt added 5 commits April 14, 2023 13:03
with  virtual methods to be overriden
- for now only WebARKitOrbTracker is a derived class
of WebARKitAkazeTracker class
@kalwalt
Copy link
Owner Author

kalwalt commented Apr 19, 2023

i have created the new WebARKitTracker class, it seems that is correct; I will remove emscripten code from it. I think that is not necessary, better to mantain free from emscripten includes.

@kalwalt
Copy link
Owner Author

kalwalt commented Apr 19, 2023

I did all the planned changes, i think it is time to move on. I will transfer the code in the original repository and i will close this PR as said.

kalwalt added a commit to webarkit/WebARKitLib that referenced this pull request Apr 25, 2023
@kalwalt
Copy link
Owner Author

kalwalt commented May 1, 2023

I migrated the code so i can close this. For more infos see webarkit/webarkit-testing#15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant