Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Abstract classes for the code base #13

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Conversation

kalwalt
Copy link
Member

@kalwalt kalwalt commented Apr 19, 2023

WebARKitTracker abstract class

These changes in WebARKitLib will be latest before creating a new branch in it and release the code.
As mentioned in
kalwalt/WebARKitLib#4 i'm creating an abstract class WebARKitTracker from which other classes will be derived.

List of changes

WebARKitLib changes

  • new WebARKitTracker class as abstract class for other *Tracker classes.
  • removed emscripten code from WebARKitTrackers classes
  • cleaned code with less couts and comments

WebARKitController changes

  • Orb and Akaze examples (also in live examples/doc folde)
  • updated code due to changes in WebARKitLib (see below)

kalwalt added 2 commits April 19, 2023 20:22
- change WebARKitAkazeTracker as derived class of WebARKitTracker
@kalwalt kalwalt added enhancement New feature or request javascript Emscripten / C / C++ all about Emscripten labels Apr 19, 2023
@kalwalt kalwalt self-assigned this Apr 19, 2023
- provide two examples as the supported Trackers
@kalwalt kalwalt merged commit 104f31f into main Apr 19, 2023
@kalwalt kalwalt deleted the WebARKitTracker-abstract-class branch May 3, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Emscripten / C / C++ all about Emscripten enhancement New feature or request javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant