Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): new icon style #693

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

feat(icons): new icon style #693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/src/icons.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ export type IconProps =
| 'reload'
| 'replay'
| 'search-off'
| 'style'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n entendi o nome desse ícone... oq é?

Copy link
Contributor Author

@anabrook anabrook Jan 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MayaraRMA eu peguei esse nome do DS do figma

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oq ele representa?

Copy link
Contributor Author

@anabrook anabrook Jan 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MayaraRMA ele seria um icone default para quando entra um departamento novo que não foi mapeado.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhmm, the icon's name is a bit weird, is a good idea thinking about it

Copy link
Contributor Author

@anabrook anabrook Jan 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put it as a style_chart? @felipefialho @gabrielduete @MayaraRMA

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked it! we just need the kebab-case

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anabrook Uhmm, I don't know if `style-chart' tells about this icon, could u try to use some tool of AI to analyze it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unmaped-new-departament or new-tag or new-department-tag, something like that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked this new-department-tag, @MayaraRMA. Can we continue with this name?

| 'sentiment-dissatisfied'
| 'share-variant-outline'
| 'share-variant'
Expand Down
10 changes: 10 additions & 0 deletions packages/icons/svg/mdi/style.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading