-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): new icon style #693
base: main
Are you sure you want to change the base?
Conversation
Quality Gate passed for 'juntossomosmais_atomium_core'Issues Measures |
|
@@ -176,6 +176,7 @@ export type IconProps = | |||
| 'reload' | |||
| 'replay' | |||
| 'search-off' | |||
| 'style' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n entendi o nome desse ícone... oq é?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MayaraRMA eu peguei esse nome do DS do figma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oq ele representa?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MayaraRMA ele seria um icone default para quando entra um departamento novo que não foi mapeado.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uhmm, the icon's name is a bit weird, is a good idea thinking about it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gabrielduete We already have a tag
icon on Material Icons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put it as a style_chart? @felipefialho @gabrielduete @MayaraRMA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked it! we just need the kebab-case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anabrook Uhmm, I don't know if `style-chart' tells about this icon, could u try to use some tool of AI to analyze it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unmaped-new-departament or new-tag or new-department-tag, something like that
What is being delivered?
Add icons:
What impacts?