Add start page #59
Closed
Add start page #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essential cookies do not require user consent under the regulations, but you do still have to tell users about what cookies are used. In this case, cookies are defined as anything that stores data on the user’s device. The GOV.UK Design System recommends adding a page for the cookies policy and linking to it from the footer; so this replicates that.
1. Wrap breadcrumbs in a block so that they can be amended on other pages (such as on the cookies page). 2. Add `<li>` tag to footer links (to correct earlier error)
Add a separate link for the privacy policy and cookies.
The routing to the privacy policy page wasn’t right
The error code said “Expected two blank lines”, so adding extra lines!
Essential cookies do not require user consent under the regulations, but you do still have to tell users about what cookies are used. In this case, cookies are defined as anything that stores data on the user’s device. The GOV.UK Design System recommends adding a page for the cookies policy and linking to it from the footer; so this replicates that.
1. Wrap breadcrumbs in a block so that they can be amended on other pages (such as on the cookies page). 2. Add `<li>` tag to footer links (to correct earlier error)
Add a separate link for the privacy policy and cookies.
The routing to the privacy policy page wasn’t right
The error code said “Expected two blank lines”, so adding extra lines!
Further to @jonodrew’s [feedback on breadcrumb blocks](#51 (comment)), I think this reduces the repetition of code and is marginally more ‘DRY’.
This commit changes the use of `{% block %}` on all pages to create a header that can then be set using:
- `block pagecaption`
- `block pageheading`
- `block pagecontent`
added 2 commits
February 13, 2022 12:19
- Rename the original `index.html` template to `match.html` - Create a route to `/match` for `match.html` - Add start page placeholder text (will need to be updated when tool is complete)
Closed
4 tasks
|
I think I'm right in saying that this doesn't necessarily need #51 in order to be merged. Rather than having a branch-of-a-branch and having to keep everything in sync, can you please create a new branch from main and cherry-pick the commits onto that? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further to discussion on #49, this adds routes for a separate
startandmatchpage; with the former being the index.Users are now presented with help text and a Start now button when starting the tool.
Note: this is a branch of #51 so they stay in sync. 6514346 is the first meaningful commit in this branch.