Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add start page #61

Merged
merged 15 commits into from
Feb 16, 2022
Merged

Add start page #61

merged 15 commits into from
Feb 16, 2022

Conversation

johnpeart
Copy link
Collaborator

  1. Move index.html to match.html
  2. Change index.html content to the start page
  3. Add routes to routes.py

Add start page
d9f54e2 
1. Move `index.html` to `match.html`
2. Change `index.html` content to the start page
3. Add routes to `routes.py`
@johnpeart johnpeart requested a review from jonodrew February 14, 2022 22:12
@johnpeart johnpeart added the enhancement New feature or request label Feb 14, 2022
@johnpeart johnpeart linked an issue Feb 14, 2022 that may be closed by this pull request
Proposal: Start page #49
Closed
4 tasks
@github-actions
Copy link

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.9.10-final-0 -----------

Name Stmts Miss Cover
app/init.py 16 0 100%
app/auth/init.py 3 0 100%
app/auth/routes.py 23 13 43%
app/config.py 10 1 90%
app/extensions.py 3 0 100%
app/helpers.py 10 1 90%
app/main/init.py 3 0 100%
app/main/routes.py 81 20 75%
app/tasks/init.py 11 2 82%
app/tasks/tasks.py 11 5 55%
TOTAL 171 42 75%
======================== 16 passed, 4

@johnpeart
Copy link
Collaborator Author

A cleaner attempt now #51 is merged in, @jonodrew. (#59 did require #51 because of the changes I'd made to the block; but we don't need to worry about that now!)
I've deleted the other branch.

jonodrew
jonodrew requested changes Feb 15, 2022
View reviewed changes
Copy link
Owner

@jonodrew jonodrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I'm not sure why the match page forms part of the user journey. I think now we've got a full upload/download user journey, the start page should integrate with that?

app/templates/index.html Outdated Show resolved Hide resolved
app/templates/index.html Outdated Show resolved Hide resolved
jonodrew
jonodrew requested changes Feb 15, 2022
View reviewed changes
app/templates/index.html Outdated Show resolved Hide resolved
@jonodrew
Copy link
Owner

jonodrew commented Feb 15, 2022 via email •
edited
Loading

John Peart added 5 commits February 15, 2022 19:45
Put the error message on one line
48e84b6 
This reads a little neater I think!
Amend links
3c26ae3 
1. Add link to spreadsheet template
2. Change route link
Tidy up the input form a little
eec3061 
Change the title of the page to be more directive about the step in the journey.

Move the  error message into the form.

Remove the heading and increase the label size instead.

Change the button text.
We don't need this anymore!
47d058c
Mirror the changes on the process page.
54aff37
@johnpeart
Copy link
Collaborator Author

I've made a few amends to:
(a) fix the routes to use the actual process
(b) tidy up the styles a bit
(c) other minor miscellaneous changes

I think it all works! Very exciting!

jonodrew
jonodrew approved these changes Feb 15, 2022
View reviewed changes
Copy link
Owner

@jonodrew jonodrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for doing this. It looks great!

John Peart added 7 commits February 16, 2022 16:28
@jonodrew
Add start page
be9e94b 
1. Move `index.html` to `match.html`
2. Change `index.html` content to the start page
3. Add routes to `routes.py`
@jonodrew
Fix unit test
1334e64
@jonodrew
Put the error message on one line
0f84209 
This reads a little neater I think!
@jonodrew
Amend links
6293eb1 
1. Add link to spreadsheet template
2. Change route link
@jonodrew
Tidy up the input form a little
d195212 
Change the title of the page to be more directive about the step in the journey.

Move the  error message into the form.

Remove the heading and increase the label size instead.

Change the button text.
@jonodrew
We don't need this anymore!
9920841
@jonodrew
Mirror the changes on the process page.
f7fc837
@johnpeart
Copy link
Collaborator Author

@jonodrew are we ready to merge this one in?

@jonodrew
Copy link
Owner

👍🏻 Hit the button John!

@johnpeart johnpeart merged commit 3596755 into main Feb 16, 2022
@johnpeart johnpeart deleted the start-page branch February 16, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonodrew jonodrew jonodrew approved these changes

Assignees

@jonodrew jonodrew

@johnpeart johnpeart

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Start page
2 participants
@johnpeart @jonodrew