Bundle Ubuntu font resource instead of using as downloadable font #249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting this change out from #240.
Simply bundles the actual Ubuntu font .ttf instead of referencing Ubuntu as a downloadable font.
As a bit of history, Slim-Launcher previously bundled the Ubuntu
.ttf
files before switching to the downloadable font format. However, downloadable fonts require a font provider to be available in Android.Now, in my experience, many Android distros (e.g. LineageOS and GrapheneOS) seem to work around this somehow (perhaps by implementing their own fonts provider). I have run Unlauncher successfully on many instances of LineageOS and GrapheneOS without Google Play Services and have never seen font issues. 🤔 Be that as it may, the other downside of using downloadable fonts is that the Google fonts provider (and probably other implementations) will load the fonts from
fonts.google.com
which may not be reachable in some locations/environments. (E.g. someone may block their device from accessing anygoogle.com
domains.)I think bundling the
.ttf
for the default typeface makes sense in this case since since it is fundamental to the look/feel of Unlauncher and should not be dependent on access/availability of an external service/domain.