Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle Ubuntu font resource instead of using as downloadable font #249

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

jkuester
Copy link
Owner

@jkuester jkuester commented Jan 2, 2025

Splitting this change out from #240.

Simply bundles the actual Ubuntu font .ttf instead of referencing Ubuntu as a downloadable font.

As a bit of history, Slim-Launcher previously bundled the Ubuntu .ttf files before switching to the downloadable font format. However, downloadable fonts require a font provider to be available in Android.

A device must have Google Play services version 11 or higher to use the Google Fonts provider.

Now, in my experience, many Android distros (e.g. LineageOS and GrapheneOS) seem to work around this somehow (perhaps by implementing their own fonts provider). I have run Unlauncher successfully on many instances of LineageOS and GrapheneOS without Google Play Services and have never seen font issues. 🤔 Be that as it may, the other downside of using downloadable fonts is that the Google fonts provider (and probably other implementations) will load the fonts from fonts.google.com which may not be reachable in some locations/environments. (E.g. someone may block their device from accessing any google.com domains.)

I think bundling the .ttf for the default typeface makes sense in this case since since it is fundamental to the look/feel of Unlauncher and should not be dependent on access/availability of an external service/domain.

@jkuester jkuester force-pushed the include_ubuntu_ttf branch from 9c01225 to c4509d3 Compare January 2, 2025 18:51
@jkuester jkuester changed the title Replace reference Ubuntu font resource with actual .ttf resource Bundle Ubuntu font resource instead of using as downloadable font Jan 2, 2025
@jkuester jkuester merged commit 1a1a517 into master Jan 2, 2025
2 checks passed
@jkuester jkuester deleted the include_ubuntu_ttf branch January 2, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants