Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional color themes, Analog clock fixes and extensions, Embedded font, Concise English #240

Closed
wants to merge 26 commits into from

Conversation

moehriegitt
Copy link

@moehriegitt moehriegitt commented Jul 30, 2024

Hi!

Thank you for this project, I was totally hooked and wanted this badly, but there were tiny things that annoyed me, so here's a patch:

  • new colour themes for showing function by colour: launching and headlines are accent colours, the rest is white. This has a very elegant balance and form follows function. :-)
  • the analog clock seemed to break layout (overlapping date) => I debugged the boxes and fixed the layout
  • the home drawer did not align correctly on bottom => I debugged the boxes and fixed the layout
  • the analog clock's hour hand did not take into account the minute, but at 5:30, the hour hand should be in the middle between 5 and 6 => fixed
  • embedded ubuntu.ttf font, because my phone has no such font and I cannot install system fonts (not rooted), but the default Roboto is not nice with an elegant, text-based design like unlauncher. design is important, Ubuntu is much nicer than Roboto. I think the license is OK, Ubuntu fonts allow embedding.
  • I made the English strings a bit more concise by removing unnecessary verbs
  • I extended the analog clock to allow 0, 1, 2, 3, 4, 6, 12, or 60 ticks.

And sorry for the increasing size of this -- I did not know that the pull request automatically extends itself when I continue pushing in my fork... Anyway, I think I only did non-controversial stuff to improve this further. In particular:

  • restructured the menus to have faster access -- there is a single config page now, with the most likely item at the top (app config).
  • add shortcut support. The shortcuts appear normally in the drawer app list and can be added like an app. Normal shortcuts are disabled by default. Pinned shortcuts are enabled by default (because they are manually triggered to be generated).
  • add some standard activities. This is not really useful, because almost everything is accessible via shortcuts. But e.g. 'Settings: Home' is now a normal app-like launchy thing to put anywhere you like.

I hope you like the patches. Thanks again for the wonderful project.

**Henrik

…og clock: to my judgement, the previous overlay was not intended.
…ginal Greek, and it also requires less changes)
This was a regression after fixing to use our own style (in font patch).
@jkuester
Copy link
Owner

jkuester commented Jan 2, 2025

@moehriegitt Thanks for the patches here! I apologize for the delayed response. Life has been crazy and I have not had any time to look through them until now.

Since this is quite a lot of different things changing in the same PR, my plan is to pull groups of commits out into separate branches that can each be considered in their own PR. It will be a gradual process, but I have the first one already done: #249

If further changes/discussion is needed for any of the changes, it can happen in these separate PRs. Once all the commits have been accounted for, I will close this PR without merging it.

@jkuester
Copy link
Owner

jkuester commented Jan 5, 2025

Okay, all of the commits in this PR are now accounted for, either in commits to master or in these PROTOTYPE branches:

@jkuester jkuester closed this Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants