Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trailing slash if needed on SetUrl method #887

Merged
merged 21 commits into from
Jan 22, 2024

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Jan 14, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

following #707

Also:

  1. Remove the leading slash if it exists on the target path to avoid wrong target parsing.
  2. Comments have been added to clarify some potentially confusing lines of code.
  3. Fix failing terraform update test.

Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 added the improvement Automatically generated release notes label Jan 14, 2024
@sverdlov93 sverdlov93 requested review from eyalbe4 and yahavi January 14, 2024 14:50
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jan 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 14, 2024
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jan 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 14, 2024
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jan 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 14, 2024
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jan 15, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 15, 2024
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jan 15, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 15, 2024
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jan 15, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 15, 2024
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jan 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 18, 2024
artifactory/services/utils/specutils.go Outdated Show resolved Hide resolved
Signed-off-by: Michael Sverdlov <[email protected]>
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jan 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 22, 2024
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jan 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 22, 2024
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jan 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 22, 2024
Signed-off-by: Michael Sverdlov <[email protected]>
@sverdlov93 sverdlov93 merged commit 906763a into jfrog:dev Jan 22, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants