Improve SetUrl Logic to handle $URL and $URL/.

[joshrosso]

Is your feature request related to a problem? Please describe.

As a new user, I struggled to determine why I was getting 404s on my API requests. Turns out, I was setting the URL as:

ac := auth.NewArtifactoryDetails()
ac.SetUrl("https://${ORG_NAME}.jfrog.io/artifactory")

And thus the config was resolving as https://${ORG_NAME}.jfrog.io/artifactoryapi.

I'd expect SetUrl to handle both of these cases:

jfrog-client-go/auth/servicedetails.go

Lines 129 to 131 in ac964ba

	func (ccf *CommonConfigFields) SetUrl(url string) {
	ccf.Url = url
	}

Just figured I'd pass this feedback/suggestion on from the perspective of a new user 😃. If it's not desirable behavior for the project, feel free to close.

Thanks for your work on maintaining this library!

[AF250329]

yes... it took me hours to understand why HTTP request fails.... all because of the missing / at the end

[sverdlov93]

Hi @joshrosso @AF250329
Thanks for reporting this issue.
Our apologies for the inconvenience caused by this.
This PR should fix it.
I will update this thread once the next release will be out.

[sverdlov93]

Hi @joshrosso @AF250329
Version 1.36.0 has been released!
We are looking forward to your feedback on it.