New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Gradle system properties with spaces #2357

Merged

omerzi merged 22 commits into jfrog:dev from omerzi:handle-gradle-system-props

Dec 20, 2023

Member

omerzi commented Dec 13, 2023

All tests have passed. If this feature is not already covered by the tests, new tests have been added.
The pull request is targeting the dev branch.
The code has been validated to compile successfully by running go vet ./....
The code has been formatted properly using go fmt ./....

Based on:
jfrog/jfrog-cli-core#1072
jfrog/build-info-go#219


          Update dependencies

92b2b89

omerzi added safe to test improvement labels

omerzi requested a review from yahavi

December 13, 2023 07:27

omerzi had a problem deploying to frogbot

December 13, 2023 07:27

— with

GitHub Actions Failure


          Merge remote-tracking branch 'upstream/dev' into handle-gradle-system…

9a42b8c

…-props

# Conflicts:
#	go.mod
#	go.sum

github-actions bot removed the safe to test label

omerzi had a problem deploying to frogbot

December 13, 2023 07:28

— with

GitHub Actions Failure

omerzi added the safe to test label

github-actions bot removed the safe to test label


          Update tests

4bffd64

omerzi had a problem deploying to frogbot

December 13, 2023 07:32

— with

GitHub Actions Failure

omerzi added the safe to test label

github-actions bot removed the safe to test label


          Update tests

813f940

omerzi had a problem deploying to frogbot

December 13, 2023 08:14

— with

GitHub Actions Failure

omerzi added the safe to test label

github-actions bot removed the safe to test label


          Update tests

00b7b62

omerzi had a problem deploying to frogbot

December 13, 2023 08:31

— with

GitHub Actions Failure

omerzi added the safe to test label

github-actions bot removed the safe to test label


          Update core

7170bc3

omerzi had a problem deploying to frogbot

December 17, 2023 10:03

— with

GitHub Actions Failure

omerzi requested a review from eyalbe4

December 17, 2023 10:03

omerzi mentioned this pull request

Gradle fix jfrog/build-info-go#184

Closed

4 tasks


          Merge branch 'dev' into fix-gradle-tasks-split

a2cc64a

omerzi had a problem deploying to frogbot

December 17, 2023 14:41

— with

GitHub Actions Failure


          Merge branch 'dev' into fix-gradle-tasks-split

8c47cae

omerzi had a problem deploying to frogbot

December 17, 2023 14:45

— with

GitHub Actions Failure

omerzi had a problem deploying to frogbot

December 17, 2023 14:52

— with

GitHub Actions Failure

omerzi added the safe to test label

github-actions bot removed the safe to test label

omerzi added 2 commits

December 17, 2023 17:01


          Merge remote-tracking branch 'origin/handle-gradle-system-props' into…

a940ac4

… handle-gradle-system-props


          Merge remote-tracking branch 'origin/handle-gradle-system-props' into…

197ba37

… handle-gradle-system-props

omerzi had a problem deploying to frogbot

December 17, 2023 15:02

— with

GitHub Actions Failure


          Merge remote-tracking branch 'origin/handle-gradle-system-props' into…

415f44f

… handle-gradle-system-props

omerzi had a problem deploying to frogbot

December 17, 2023 15:03

— with

GitHub Actions Failure

omerzi added the safe to test label

github-actions bot removed the safe to test label

omerzi added 2 commits

December 17, 2023 17:11


          Merge remote-tracking branch 'origin/handle-gradle-system-props' into…

c2c9ae1

… handle-gradle-system-props


          Merge remote-tracking branch 'origin/handle-gradle-system-props' into…

5a998d3

… handle-gradle-system-props

omerzi had a problem deploying to frogbot

December 17, 2023 15:12

— with

GitHub Actions Failure

omerzi added the safe to test label

github-actions bot removed the safe to test label

eyalbe4 added bug and removed improvement labels

eyalbe4 approved these changes

View reviewed changes


          Merge branch 'dev' into fix-gradle-tasks-split

84a54fb

omerzi had a problem deploying to frogbot

December 20, 2023 10:39

— with

GitHub Actions Failure

omerzi added 4 commits

December 20, 2023 13:15


          Merge branch 'dev' into fix-gradle-tasks-split

2a1033c


          Merge remote-tracking branch 'upstream/dev' into handle-gradle-system…

cd8f0d1

…-props

# Conflicts:
#	go.mod
#	go.sum


          Merge branch 'dev' into fix-gradle-tasks-split

fa9a10e


          Merge remote-tracking branch 'origin/handle-gradle-system-props' into…

b439f40

… handle-gradle-system-props

# Conflicts:
#	go.mod
#	go.sum

omerzi had a problem deploying to frogbot

December 20, 2023 11:17

— with

GitHub Actions Failure

omerzi added the safe to test label

github-actions bot removed the safe to test label

omerzi merged commit 1fd4226 into jfrog:dev

62 of 63 checks passed

BrewTestBot mentioned this pull request

jfrog-cli 2.52.6 Homebrew/homebrew-core#157933

Merged

gregoryboue mentioned this pull request

Bad handling of gradle CLI opts since 2.52.6 #2397

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug