Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad handling of gradle CLI opts since 2.52.6 #2397

Closed
gregoryboue opened this issue Jan 3, 2024 · 6 comments
Closed

Bad handling of gradle CLI opts since 2.52.6 #2397

gregoryboue opened this issue Jan 3, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@gregoryboue
Copy link

Describe the bug

Since 2.52.6 release and this PR : #2357 , some properties like -Dorg.gradle.internal.plugins.portal.url.override=https://myartifactory.org/artifactory/maven-public/ are not interpreted anymore.

In a context of a company with only access to maven repository through Artifactory, we have to use this property to download gradle plugins with artifactory because the JFrog CLI can't do that.

Current behavior

Since 2.52.6 version, if i launch : jf gradle clean assemble -Dorg.gradle.internal.plugins.portal.url.override=https://myartifactory.org/artifactory/maven-public/, the plugins needed by my project is not downloaded through artifactory anymore.

Reproduction steps

With a simple gradle project with gradle sonarqube plugin used in the build.gradle.

  • With JFROG CLI 2.52.6+
  • Use gradle wrapper 7.2 and java 11/17
  • Run jf gradle-config to resolve dependency from artifactory (proxy to maven-central required)
  • run jf gradle clean assemble --info -Dorg.gradle.internal.plugins.portal.url.override=https://myartifactory.org/artifactory/maven-public/

Then the log show that the repository https://myartifactory.org/artifactory/maven-public/ is not used to resolve gradle plugin (and the command is in error if there is no network access to https://plugins.gradle.org/m2/

The same command is ok with 2.52.5 version.

Expected behavior

That the opt is well interpreted by JFrog CLI and https://myartifactory.org/artifactory/maven-public/ is used for gradle plugin resolution

JFrog CLI version

2.52.6+

Operating system type and version

Ubuntu

JFrog Artifactory version

7.55.10

JFrog Xray version

3.79.11

@gregoryboue gregoryboue added the bug Something isn't working label Jan 3, 2024
@omerzi
Copy link
Member

omerzi commented Jan 3, 2024

Hey @gregoryboue, thank you for reporting this issue. We've made changes since the relevant PR you mentioned. These changes take effect in JFrog CLI v2.52.8. Have you tried this version? Thanks.

@gregoryboue
Copy link
Author

Hi @omerzi,

I have the same behaviour with v2.52.8.

@omerzi
Copy link
Member

omerzi commented Jan 4, 2024

Hi @gregoryboue, could you please attach the debug logs? To set the debug logs you need to add the JFROG_CLI_LOG_LEVEL environment variable and set it to DEBUG. It would assist us in further investigating this issue, thank you.

@gregoryboue
Copy link
Author

gregoryboue commented Jan 4, 2024

Hi @omerzi You can find the logs in the following file :

jfgradle.log

@omerzi
Copy link
Member

omerzi commented Jan 8, 2024

Hi @gregoryboue, we've released JFrog CLI v2.52.9 with a gradle command parameter handling fix. Please let us know if this resolves your issue. Thank you.

@gregoryboue
Copy link
Author

@omerzi , I can confirm that the issue is fixed in v2.52.9 , thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants