Fix macos 13 build #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes code and comments originally introduced in 756c6e5 (BUG: Support for QtWebEngine requires C++14 support)
This was referenced Jan 13, 2023
Merged
This was
linked to
issues
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating
computronmacOS version from macOS 10.15 (Catalina) to macOS 13.0 (Ventura), python 2.7 originally available on macOS 10.15 now required to explicitly built.To support building Qt 5.15.2 on macOS 13.0, the patch corresponding to qt/qtbase@8467beddb (
Add missing macOS header file that was indirectly included before) needs to be applied.