Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update computron system & script #52

Closed
6 of 7 tasks
jcfr opened this issue Jan 7, 2023 · 5 comments · Fixed by #53 or #57
Closed
6 of 7 tasks

Update computron system & script #52

jcfr opened this issue Jan 7, 2023 · 5 comments · Fixed by #53 or #57

Comments

@jcfr
Copy link
Member

jcfr commented Jan 7, 2023

Since the macOS 10.15 (Catalina) is obsolete, the system should be updated.

Related issues and pull-requests:

Footnotes

  1. https://github.com/Slicer/DashboardScripts/blob/2280c47d6633b9cc155fa412cf6f647afc083717/computron-slicer_preview_nightly.cmake

  2. https://github.com/Slicer/DashboardScripts/blob/2280c47d6633b9cc155fa412cf6f647afc083717/computron-slicerextensions_preview_nightly.cmake

@jcfr
Copy link
Member Author

jcfr commented Jan 7, 2023

The operating system has been updated to macOS 13 (Ventura)

$ sw_vers   
ProductName:         macOS
ProductVersion:      13.0.1
BuildVersion:        22A400

@jcfr
Copy link
Member Author

jcfr commented Jan 8, 2023

image image

Since current version still reports 11.7:

$ xcodebuild -version  
Xcode 11.7
Build version 11E801a

$ xcode-select -p
/Applications/Xcode_11.7.app/Contents/Developer

... Xcode version 14.2 installation folder was first renamed and then set as default using xcode-select:

$ sudo mv /Applications/Xcode.app /Applications/Xcode-14.2.app

$ sudo xcode-select -s /Applications/Xcode-14.2.app/Contents/Developer

$ xcode-select -p                                            
/Applications/Xcode-14.2.app/Contents/Developer

$ xcodebuild -version 
Xcode 14.2
Build version 14C18

$ clang --version 
Apple clang version 14.0.0 (clang-1400.0.29.202)
Target: x86_64-apple-darwin22.1.0
Thread model: posix
InstalledDir: /Applications/Xcode-14.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

@jcfr
Copy link
Member Author

jcfr commented Jan 9, 2023

Command used to build Qt 5.15.2 is the following:

cd /D/Support/qt-easy-build
git checkout 5.15.2
cd /D/Support/
./qt-easy-build/Build-qt.sh -s macosx13.1 -d 11 -j 4

Additionally patch adapted from microsoft/vcpkg#21055 was also integrated to workaround build issue. Once I confirm the build completes, I will associated the patch with the 5.15.2 branch.

Based on my understanding the target deployement platform specified when building Qt (macOS 11) is consistent with Slicer/Slicer#6695

@jamesobutler Did I miss anything ?

@jamesobutler
Copy link
Contributor

I think you are doing everything that is needed. Will ultimately need to issue the PR in this repo to update things like factory-south-macos-slicer_preview_nightly.cmake to computron-slicer_preview_nightly.cmake as part of your listed "Script Updates" to-do list.

If you can utilize the changes in Slicer/Slicer#6695 to do a sanity test to make sure "11.0" is correct would be helpful. It's a little weird with the change of the yearly release being the major version number now.

@jcfr
Copy link
Member Author

jcfr commented Jan 9, 2023

re: patch Qt 5.15.2

Turns out the fixes has already been included in the qt/[email protected] branch.

See qt/qtbase@8467bed (Add missing macOS header file that was indirectly included before)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants