Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in dependency cycle check #909

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Fix regression in dependency cycle check #909

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50bf79a
Corner case of empty runtime dependencies
LaurentRDC Nov 30, 2021
38d9d73
Merge remote-tracking branch 'upstream/master' into issue-907
LaurentRDC Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/Hakyll/Core/Runtime.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,10 @@ chase id' = do

-- Progress has been made if at least one of the
-- requirements can move forwards at the next pass
let progress | length deps < length reqs = Progressed
| otherwise = Idled
-- In some cases, dependencies have been processed in parallel in which case `deps`
-- can be empty, and we can progress to the next stage. See issue #907
let progress | null deps = Progressed
| deps == reqs = Idled
| otherwise = Progressed

return progress