Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in dependency cycle check #909

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Fix regression in dependency cycle check #909

merged 2 commits into from
Dec 3, 2021

Conversation

LaurentRDC
Copy link
Collaborator

This PR fixes #907, which triggered a corner case of the dependency cycle checking.

This patch was tested on the issue author's test case here: https://github.com/jtojnar/repro/tree/main/hakyll-poc-messed-cycle

@jtojnar Can you confirm that with this patch, you can compile your full site?

Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm it fixes my issue.

@Minoru
Copy link
Collaborator

Minoru commented Dec 3, 2021

Thanks!

I got curious what produces a CompilerRequire [] c result. Apparently it's this line: content/en/index.html or content/cs/index.html don't have a "destination" version, so a pattern returns no results, and thus this line uses an empty ids list.

@Minoru Minoru merged commit 48aa465 into jaspervdj:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency checking regression
3 participants