feat(modules): reload modules and compilation cache #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Samy-33
commented
Dec 28, 2024
•
Samy-33
commented
Samy-33
force-pushed
the
feat/require-reload
branch
from
4342f7c to
5379be0
Compare
Samy-33
changed the title
jeaye
requested changes
Jan 2, 2025
Comment on lines
+468
to
+474
| /* While loading an object, if the main ns loading symbol exists, then | ||
| * we don't need to load the object file again. | ||
| * | ||
| * Existence of the `jank_load_<module>` symbol (also a function), | ||
| * means that all the required symbols exist and are already defined. | ||
| * We call this symbol to re-initialize all the vars in the namespace. | ||
| * */ |
There was a problem hiding this comment.
So this means that it'll be impossible, in jank, to:
- Load a module from an object file
- Change the source behind that module
- Try to require the module again, to reload it
- Get the updated source
What does Clojure do here?
There was a problem hiding this comment.
If the source is more recent than the object file, we will always load from source.
Clojure doesn't load from class files, while reloading in the repl.
There was a problem hiding this comment.
Let me know, if this makes sense?
jeaye
reviewed
Jan 16, 2025
|
Handles #139 : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.