run-main only works on namespaces relative to where jank is

[elken]

Apologies if this is already raised, I had a quick look but came up nought.

So one of the testers I asked to demo my homebrew package found out that jank run-main only seems to work when the module is relative to where jank is installed. (I'm on macos, so ignore the fact it says /private/tmp instead of /tmp, they're the same path)

In this screenshot, there is a file in test/jank.jank with the below contents

(ns test.jank)

(defn count-up [max]
        (loop [count 0]
          (if (= count max)
            (println "Done!")
            (do
              (println (str "Counting " count))
              (recur (inc count))))))

(defn -main [& args]
  (count-up 5))

Doesn't work with the homebrew output build above. If I navigate to my local build instead, it does work

Then if I try and call this build (I thought maybe my homebrew build didn't set something up right), it fails as before

Hopefully this is enough to go on! Thanks as always 😄

[jeaye]

Thanks for the detailed report.

Looks to me like we're not finding the module at all when we walk through the module paths. I'd also expect a jank --module-path "$(pwd)" repl with a (require 'test.jank) to fail similarly, if that's the case. It would also mean it's nothing to do with run-main but instead how we're walking the module paths.

Getting @Samy-33 in on this.

[Samy-33]

Not reproducible on arch:

➜  pwd
/home/saket/tmp
➜  tree .
.
└── test
    └── jank.jank

2 directories, 1 file
➜  cat test/jank.jank
───────┬───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       │ File: test/jank.jank
───────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   │ (ns test.jank)
   2   │
   3   │ (defn -main [& args]
   4   │   (println "Hello world"))
───────┴───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
➜  ~/Documents/oss/jank/compiler+runtime/build/jank --module-path="$(pwd)" run-main test.jank
Bottom of clojure.core
Hello world
➜ 

[Samy-33]

Followed this process on Mac M1:

• brew tap jank-lang/jank
• brew install jank

➜  pwd
/Users/saket/Documents/oliv/tmp


➜  tree test
test
└── jank.jank

1 directory, 1 file


➜  cat test/jank.jank
(ns test.jank)

(defn count-up [max]
        (loop [count 0]
          (if (= count max)
            (println "Done!")
            (do
              (println (str "Counting " count))
              (recur (inc count))))))

(defn -main [& args]
  (count-up 5))


➜  jank --module-path $(pwd) run-main test.jank
Bottom of clojure.core
Counting 0
Counting 1
Counting 2
Counting 3
Counting 4
Done!


➜  

[Samy-33]

Issue replicated:

➜  jank --module-path "$(pwd)" compile test.jank
Bottom of clojure.core


➜  jank --module-path "$(pwd)" run-main test.jank
Bottom of clojure.core
Exception: can't intern var; namespace doesn't exist: test.jank


➜  

@elken, can you confirm the same behaviour on your mac?

• Remove the compiled files from the classes directory
• Then run-main

Note: classes exists in the same directory you ran the compile command in.

[elken]

Confirmed! That does it, you're right 😄

[Samy-33]

Surprisingly, jank --module-path src repl and then (require 'core) works fine.

➜  dev git:(main) ✗ pwd
/Users/saket/Documents/oss/jank/compiler+runtime/dev
➜  dev git:(main) ✗ tree .
.
├── classes
│   └── core.o
└── src
    ├── core.jank
    └── jank-lein
        └── core.clj

4 directories, 3 files
➜  dev git:(main) ✗ cat src/core.jank
(ns core)

(defn -main [& args]
  (println "Hello world"))

(println "Bottom of core")

➜  dev git:(main) ✗ which jank
/opt/homebrew/bin/jank
➜  dev git:(main) ✗ jank --module-path src repl
Bottom of clojure.core
clojure.core=> (require 'core)
Bottom of core
nil
clojure.core=> (in-ns 'core)
nil
core=> (-main)
Hello world
nil
core=>

[elken]

Yep I can repro that also

[Samy-33]

The Homebrew Formual is on system-boehm branch. Building from main solved the issue. I don't have a root cause, but perhaps improvements in module loading resulted into fixing this case as well.

Thanks @elken for helping with reproduction and homebrew wizardry.

[elken]

I think it was #155 that fixed it, it's the only obvious change since boehm was merged in