Using the openshift profile is deprecated in favor of setting the openshift platform
#16051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…latform Signed-off-by: Benjamin Leggett <[email protected]>
istio-testing
added
the
size/XS
bleggett
changed the title
openshift profile is deprecated in favor of setting the platformopenshift profile is deprecated in favor of setting the openshift platform
|
|
||
| {{< text bash >}} | ||
| $ istioctl install --set profile=openshift | ||
| $ istioctl install --set values.global.platform=openshift |
There was a problem hiding this comment.
@bleggett, this command does not enable CNI which is required for OpenShift. Please see...
$: istioctl install --set values.global.platform=openshift
|\
| \
| \
| \
/|| \
/ || \
/ || \
/ || \
/ || \
/ || \
/______||__________\
____________________
\__ _____/
\_____/
This will install the Istio 1.24.0 profile "default" into the cluster. Proceed? (y/N) y
✔ Istio core installed ⛵️
✔ Istiod installed 🧠
✔ Ingress gateways installed 🛬
✔ Installation complete
$: k get pods -n kube-system
NAME READY STATUS RESTARTS AGE
coredns-58696f69f5-ndwkq 1/1 Running 0 98d
OTOH, if we use the openshift profile...
$: istioctl install --set profile=openshift
|\
| \
| \
| \
/|| \
/ || \
/ || \
/ || \
/ || \
/ || \
/______||__________\
____________________
\__ _____/
\_____/
This will install the Istio 1.24.0 profile "openshift" into the cluster. Proceed? (y/N) y
✔ Istio core installed ⛵️
✔ Istiod installed 🧠
✔ Ingress gateways installed 🛬
✔ CNI installed 🪢
✔ Installation complete
$: k get pods -n kube-system
NAME READY STATUS RESTARTS AGE
coredns-58696f69f5-ndwkq 1/1 Running 0 98d
istio-cni-node-4s7vj 1/1 Running 0 36s
istio-cni-node-78jhz 1/1 Running 0 36s
istio-cni-node-9klq6 1/1 Running 0 36s
istio-cni-node-lff9v 1/1 Running 0 36s
istio-cni-node-wkdm7 1/1 Running 0 36s
istio-cni-node-xpbnz 1/1 Running 0 36s
$
There was a problem hiding this comment.
We'll have to modify the command as follows
istioctl install --set components.cni.enabled=true --set components.cni.namespace=kube-system --set values.global.platform=openshift
There was a problem hiding this comment.
We'll have to modify the command as follows
istioctl install --set components.cni.enabled=true --set components.cni.namespace=kube-system --set values.global.platform=openshift
Yeah - ideally (since we don't use Helm wrapper charts to conditionally select components) platform and profile should be purely Helm overrides, and istioctl should infer what components to choose based on the value of platform. Right now it's kind of all over the place, and we have two different kinds of profile that have different effects, depending on the install method, and then platform which is shared across both.
That just confuses people.
Lemme see if I can improve this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openshift is a platform, not a profile. This is important because we want people to be able to specifiy platform and profile independently (e.g.
--set values.global.platform=gke --set values.global.profile=ambient), and also want to share the same profiles and platforms betweenistioctlandhelm.Fixup for #16049
Description
Reviewers