Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix istioctl install command for OpenShift #16049

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix istioctl install command for OpenShift #16049

merged 1 commit into from
Dec 4, 2024

Conversation

sridhargaddam
Copy link
Contributor

Fixes: #16047

@sridhargaddam sridhargaddam requested review from a team as code owners December 4, 2024 19:05
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 4, 2024
@istio-testing istio-testing merged commit cfd6225 into istio:master Dec 4, 2024
5 of 6 checks passed
bleggett
bleggett reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@bleggett bleggett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't correct, profile and platform are not the same.

You can for instance have something like --profile=ambient --platform=openshift

@bleggett
Copy link
Contributor

bleggett commented Dec 4, 2024

@sridhargaddam can you correct? platform and profile are 2 different things, and you can have both.

openshift is a platform, not a profile.

bleggett
bleggett reviewed Dec 4, 2024
View reviewed changes
content/en/docs/setup/platform-setup/openshift/index.md
@@ -16,7 +16,7 @@ Follow these instructions to prepare an OpenShift cluster for Istio.
Install Istio using the OpenShift profile:

{{< text bash >}}
$ istioctl install --set global.platform=openshift
$ istioctl install --set profile=openshift
Copy link
Contributor

@bleggett bleggett Dec 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be istioctl install --set values.global.platform=openshift - using the Helm values.

istioctl-only profiles via --set profile are/should be deprecated, and openshift is now a platform, and not a profile.

This is so we can compose like so: istioctl install --set values.global.platform=openshift --set values.global.profile=ambient and also share platforms and profiles between helm and istioctl without duplicating.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay Ben. We can continue with your PR - https://github.com/istio/istio.io/pull/16051/files

@bleggett bleggett mentioned this pull request Dec 4, 2024
Open
11 tasks
@bleggett
Copy link
Contributor

bleggett commented Dec 4, 2024

NVM, fixed in #16051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bleggett bleggett bleggett left review comments

@kfaseela kfaseela kfaseela approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The OpenShift installation instructions don't work
4 participants
@sridhargaddam @bleggett @kfaseela @istio-testing