Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support getting attachments #3

Merged
merged 3 commits into from
May 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@intacct-thyme/intacct-sdk",
"version": "2.2.1",
"version": "2.2.2-fork.0",
"description": "Sage Intacct SDK for JavaScript",
"main": "dist/index.js",
"types": "dist/index.d.ts",
Expand Down
39 changes: 39 additions & 0 deletions src/Functions/Company/AttachmentGet.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
/**
* @module Intacct/SDK/Functions/Company
*/

/**
* Copyright 2022 Sage Intacct, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License"). You may not
* use this file except in compliance with the License. You may obtain a copy
* of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* or in the "LICENSE" file accompanying this file. This file is distributed on
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/

import IaXmlWriter from "../../Xml/IaXmlWriter";
import AbstractFunction from "../AbstractFunction";

export default class AttachmentGet extends AbstractFunction {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other Attachment* functions extends AbstractAttachment. I decided not to do that because it's somewhat incorrect, as not all properties are defined.

public attachmentsId: string;

public writeXml(xml: IaXmlWriter): void {
xml.writeStartElement("function");
xml.writeAttribute("controlid", this.controlId, true);

xml.writeStartElement("get");

xml.writeAttribute("object", "supdoc");
xml.writeAttribute("key", this.attachmentsId, true);

xml.writeEndElement(); // get

xml.writeEndElement(); // function
}
}
1 change: 1 addition & 0 deletions src/Functions/Company/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export { default as AllocationCreate } from "./AllocationCreate";
export { default as AllocationDelete } from "./AllocationDelete";
export { default as AllocationLine } from "./AllocationLine";
export { default as AllocationUpdate } from "./AllocationUpdate";
export { default as AttachmentGet } from "./AttachmentGet";
export { default as AttachmentFile } from "./AttachmentFile";
export { default as AttachmentsCreate } from "./AttachmentsCreate";
export { default as AttachmentsDelete } from "./AttachmentsDelete";
Expand Down
48 changes: 48 additions & 0 deletions test/Functions/Company/AttachmentGetTest.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
/**
* Copyright 2022 Sage Intacct, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License"). You may not
* use this file except in compliance with the License. You may obtain a copy
* of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* or in the "LICENSE" file accompanying this file. This file is distributed on
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/

import AttachmentGet from "../../../src/Functions/Company/AttachmentGet";
import XmlObjectTestHelper from "../../Xml/XmlObjectTestHelper";

describe("AttachmentFile", () => {
before((done) => {
return done();
});
beforeEach((done) => {
return done();
});
afterEach((done) => {
return done();
});
after((done) => {
return done();
});
it("should build AttachmentGet object", () => {
const key = "1234";

const expected = `<?xml version="1.0" encoding="utf-8" ?>
<test>
<function controlid="unittest">
<get object="supdoc" key="${key}" />
</function>
</test>`;

const record = new AttachmentGet();
record.attachmentsId = key;
record.controlId = "unittest";

XmlObjectTestHelper.CompareXml(expected, record);
});
});