Support getting attachments #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnturner
commented
May 1, 2023
| @@ -1,12 +1,12 @@ | |||
| { | |||
| "name": "@intacct-thyme/intacct-sdk", | |||
| "version": "2.2.0", | |||
There was a problem hiding this comment.
This is a (minor) bug on latest. npm i needs to be run when bumping package.json when using NPM's package-lock.json.
quinnturner
commented
May 1, 2023
| import IaXmlWriter from "../../Xml/IaXmlWriter"; | ||
| import AbstractFunction from "../AbstractFunction"; | ||
|
|
||
| export default class AttachmentGet extends AbstractFunction { |
There was a problem hiding this comment.
All other Attachment* functions extends AbstractAttachment. I decided not to do that because it's somewhat incorrect, as not all properties are defined.
|
I did my part by creating an associated PR for this feature on Intacct: intacct#117 |
rudymalhi
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been tested locally by linking it in
@sit/apiand writing several unit tests.I don't know what we want to do with the versioning. I could bump it normally. One idea is to try and track closely with Intacct's version, then add some version suffix.
For example, if we update this fork to include the latest code on Intacct's version 2.2.1, then we'd have something like:
2.2.1-fork.0, or something like that. That way, we can keep track if we are missing code on the base.Alternatively, we can try and work towards merging more of our forked additions back into Intacct.